From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2869A04B7; Wed, 14 Oct 2020 11:31:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 911151DD9D; Wed, 14 Oct 2020 11:31:34 +0200 (CEST) Received: from dal2relay252.mxroute.com (dal2relay252.mxroute.com [64.40.26.252]) by dpdk.org (Postfix) with ESMTP id D81D41DD8C for ; Wed, 14 Oct 2020 11:31:31 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by dal2relay252.mxroute.com (ZoneMTA) with ESMTPSA id 17526733cc3000f106.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 14 Oct 2020 09:31:27 +0000 X-Zone-Loop: e964ec8da685cdb3b240f482579fff4a6d05f03461e6 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 8BFFF3E9FF; Wed, 14 Oct 2020 09:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mWkoPOdv6nZYavB6qflh9CG20RKfHLpegG/yVki7obk=; b=Km5faxHZChQBT3+ujjTmPX/ulU T/DaxMnIj2Q1PDOWXQhCxgQ3Iu6hfYraDD30GMc8QGyvPJOA3a6UdpdBp3GLkfyK4MTH8xx7F9klE ClF2IVMNis6QtuWzgdU8uR24KEqrehCs4oKbL/1MLXIRCQMLl8oJ3e7nYHIOYVFJZbkHNLZuskqDK b5pUNPKFA2n4dI4zCV0x6hTEXzo5YTYbBI0D+3FHAO4EjD5Cbq6/vrgZFEBVmwPJQ4Vacm3Zy8nUh PpkoFUMFaoiTW8Un0ZtSFhCWlFlSVrWaKEqlqtQUEvQbRwht2HkHCVchLbPJHRovtAhK7V6TpOC72 KPhBJ7nA==; To: Timothy McDaniel , Jerin Jacob , Neil Horman Cc: dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com References: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> <1602528169-14356-1-git-send-email-timothy.mcdaniel@intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <43309420-fbf8-1b7f-5e18-67f9661159e6@ashroe.eu> Date: Wed, 14 Oct 2020 10:31:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <1602528169-14356-1-git-send-email-timothy.mcdaniel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/10/2020 19:42, Timothy McDaniel wrote: > Add new internal wrapper function for use by pci drivers as a > .probe function to attach to an event interface. Same as > rte_event_pmd_pci_probe, except the caller can specify the name. > > Updated rte_event_pmd_pci_probe so as to not duplicate > code. Any reason why this couldn't be __rte_internal then ? > > Signed-off-by: Timothy McDaniel > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 45 ++++++++++++++++++++-------- > lib/librte_eventdev/rte_eventdev_version.map | 1 + > 2 files changed, 33 insertions(+), 13 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index a3f9244..4c215f7 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -32,28 +32,24 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev); > > /** > * @internal > - * Wrapper for use by pci drivers as a .probe function to attach to a event > - * interface. > + * Wrapper for use by pci drivers as a .probe function to attach to an event > + * interface. Same as rte_event_pmd_pci_probe, except caller can specify > + * the name. > */ > static inline int > -rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > - struct rte_pci_device *pci_dev, > - size_t private_data_size, > - eventdev_pmd_pci_callback_t devinit) > +rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + size_t private_data_size, > + eventdev_pmd_pci_callback_t devinit, > + const char *name) > { > struct rte_eventdev *eventdev; > - > - char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > - > int retval; > > if (devinit == NULL) > return -EINVAL; > > - rte_pci_device_name(&pci_dev->addr, eventdev_name, > - sizeof(eventdev_name)); > - > - eventdev = rte_event_pmd_allocate(eventdev_name, > + eventdev = rte_event_pmd_allocate(name, > pci_dev->device.numa_node); > if (eventdev == NULL) > return -ENOMEM; > @@ -90,6 +86,29 @@ rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > > /** > * @internal > + * Wrapper for use by pci drivers as a .probe function to attach to a event > + * interface. > + */ > +static inline int > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + size_t private_data_size, > + eventdev_pmd_pci_callback_t devinit) > +{ > + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > + > + rte_pci_device_name(&pci_dev->addr, eventdev_name, > + sizeof(eventdev_name)); > + > + return rte_event_pmd_pci_probe_named(pci_drv, > + pci_dev, > + private_data_size, > + devinit, > + eventdev_name); > +} > + > +/** > + * @internal > * Wrapper for use by pci drivers as a .remove function to detach a event > * interface. > */ > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 2846d04..88fb2bd 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -57,6 +57,7 @@ DPDK_21 { > rte_event_eth_tx_adapter_stop; > rte_event_pmd_allocate; > rte_event_pmd_pci_probe; > + rte_event_pmd_pci_probe_named; > rte_event_pmd_pci_remove; > rte_event_pmd_release; > rte_event_pmd_vdev_init; >