* [dpdk-dev] [PATCH] test: fix build when disabling ipsec library
@ 2019-01-17 10:15 David Marchand
2019-01-17 12:20 ` Ananyev, Konstantin
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-01-17 10:15 UTC (permalink / raw)
To: dev
Cc: mohammad.abdul.awal, bernard.iremonger, konstantin.ananyev,
declan.doherty, akhil.goyal
Caught after pulling ipsec then compile in an existing build directory.
Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Did a simple fix, we might want to have something like a _LDLIBS-y
variable but that's just cosmetic.
---
test/test/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/test/Makefile b/test/test/Makefile
index e7c8108..5641a59 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -208,7 +208,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c
SRCS-$(CONFIG_RTE_LIBRTE_BPF) += test_bpf.c
SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c
+ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)
LDLIBS += -lrte_ipsec
+endif
CFLAGS += -DALLOW_EXPERIMENTAL_API
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test: fix build when disabling ipsec library
2019-01-17 10:15 [dpdk-dev] [PATCH] test: fix build when disabling ipsec library David Marchand
@ 2019-01-17 12:20 ` Ananyev, Konstantin
2019-01-17 23:16 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ananyev, Konstantin @ 2019-01-17 12:20 UTC (permalink / raw)
To: David Marchand, dev
Cc: Awal, Mohammad Abdul, Iremonger, Bernard, Doherty, Declan, akhil.goyal
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Thursday, January 17, 2019 10:15 AM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] test: fix build when disabling ipsec library
>
> Caught after pulling ipsec then compile in an existing build directory.
>
> Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Did a simple fix, we might want to have something like a _LDLIBS-y
> variable but that's just cosmetic.
>
> ---
> test/test/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/test/test/Makefile b/test/test/Makefile
> index e7c8108..5641a59 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -208,7 +208,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c
> SRCS-$(CONFIG_RTE_LIBRTE_BPF) += test_bpf.c
>
> SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c
> +ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)
> LDLIBS += -lrte_ipsec
> +endif
>
> CFLAGS += -DALLOW_EXPERIMENTAL_API
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test: fix build when disabling ipsec library
2019-01-17 12:20 ` Ananyev, Konstantin
@ 2019-01-17 23:16 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-01-17 23:16 UTC (permalink / raw)
To: David Marchand
Cc: dev, Ananyev, Konstantin, Awal, Mohammad Abdul, Iremonger,
Bernard, Doherty, Declan, akhil.goyal
17/01/2019 13:20, Ananyev, Konstantin:
> From: David Marchand [mailto:david.marchand@redhat.com]
> >
> > Caught after pulling ipsec then compile in an existing build directory.
> >
> > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > Did a simple fix, we might want to have something like a _LDLIBS-y
> > variable but that's just cosmetic.
> >
> > ---
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 10:15 [dpdk-dev] [PATCH] test: fix build when disabling ipsec library David Marchand
2019-01-17 12:20 ` Ananyev, Konstantin
2019-01-17 23:16 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).