From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4815DA0C4A; Thu, 8 Jul 2021 09:33:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0ABFF4069C; Thu, 8 Jul 2021 09:33:03 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 6412C40687 for ; Thu, 8 Jul 2021 09:33:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9DDF45C0107; Thu, 8 Jul 2021 03:33:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 08 Jul 2021 03:33:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Lte+0fNWWD7DC343wgpwCm+54sqHkuBf2/4jyvd6Rn4=; b=WFRQH0CdvM/DrLAN 4Csi4G/XiTJNjMqH+Wg7XzsyI3c+OjTH+G+6IixoHf1kEfaIi50AuKQcae/3Mpls Yn6AR1GFUnOZ6Auq0PfctLQ+oldc/3Fr8IgYEmAENrRE4tMxDt29AsUs4h7cDbPJ lqvyCfFI0jB8FhPDVMf9eDPb7j3oFD6/bJpzO0rB51ZVo3tsptjF91nvHT3VgmHL aXpLsk/6HobTBVbuzyneEWRTSVGa/pN3XGUluq5hGekLQRvV6luIB7Hn85/B6min RszGnoJ3hKd5tnvnI/M6PFbniSo98otcZ+lxnLQb7A9S55mYvhiUkuwpXDc1zwKr BkYZcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Lte+0fNWWD7DC343wgpwCm+54sqHkuBf2/4jyvd6R n4=; b=YYRFxl2BKx5tNTej42YMsGfxkHqm6hgt/9fvqrJxr5Cu3Vibp/oRkNNl3 mWL1AW9PpLDJTGBL14vkw1hJquTG+u/mbpTJqFQMO/7F9Pdu436+cP7KAyyLLY89 4+aP0e3m8jJVWvXwjoRV8hSRiwKhuBnZGfbo8NW7f7MY4IYXtN3sxBgLxvNAB2z/ 0CJI2rqyu0XQJDbuKWh6IYuYyvLCYUXdyNdUuQFa9wC40YpFxtqwcI/0b501TlJQ ZLzrSE3fgwAb2sPB5E4UnNwYVdH8YeuwYOfkI2HrVx2jDKD/4cPPwHIEMbpPc/Mq o1qHmM2kAIgxKJWgrT/6+F2DXK/0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdefgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jul 2021 03:32:58 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang , Jerin Jacob Cc: Bruce Richardson , Jan Viktorin , "jerinj@marvell.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd , Honnappa Nagarahalli Date: Thu, 08 Jul 2021 09:32:57 +0200 Message-ID: <4337273.iQpEcjLWDA@thomas> In-Reply-To: References: <20200424070741.16619-1-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2021 08:32, Jerin Jacob: > On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang wrote: > > From: Jerin Jacob > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson > > > wrote: > > > > On Wed, Jul 07, 2021 at 06:46:33AM +0000, Ruifeng Wang wrote: > > > > > From: Thomas Monjalon > > > > > > 07/07/2021 07:48, Ruifeng Wang: > > > > > > > Introduce a meson option 'use_wfe' to select wait until equal method. > > > > > > > The default is disable. Traditional polling loop is used. > > > > > > > When enabled, architecture specific mechanism is relied on to do > > > > > > > the wait. > > > > > > > > > > > > Why do we need an option? > > > > > > Can it be automatic to enable it when supported? > > > > > > > > > > > The problem is inconsistency in performance on different Arm platforms. > > > We had decided that each platform needs to enable it after some testing. > > > > > > > > > Can that not be done via variables in the cross-file for the builds, > > > > or via automatic detection if it's a native build? Is it likely that > > > > individual users of DPDK will be knowledgable enough to use this option > > > correctly? > > > > > > +1 to add this in cross-file instead of the top of config option as > > > scope if is only for arm64 builds. > > > > Currently this option is in config/arm/meson.build (flags_common). SoCs can build > > with this option enabled/disabled. And the ability is available for both native build > > and cross build as cross build also goes through meson.build. > > If a SoC needs to enable the option by default, an entry and be added to the SoC flags. > > > > The key difference here is whether this option need to be exposed to the top level config. > > In the view of limiting top-level config options and it is specific to > Arm, I think, it better to > be a cross file only option. +1, sorry for the late notice. I would advocate to take this patch in 21.08-rc2.