From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 23EE72A9 for ; Tue, 21 Oct 2014 22:45:59 +0200 (CEST) Received: by mail-wg0-f52.google.com with SMTP id a1so2318619wgh.11 for ; Tue, 21 Oct 2014 13:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=gboNqT88LQd/ozEHnbPYRbE14lSomee0Dq5S22cmeHo=; b=f6cRWxSW3kg2kruCn+eW8ic+bko+/+PN924z026M+LRhE2KXKKuy64q4e+WRWPmGq1 K79BLmGTBKBXhkIwH7suKneVbxmXoeAq7p21mG4FgbPYbrWwzK+tWAFnk4e+3ViJkIaJ tn2465OWquSZLQZOQy/Sqr+GfhsexX+r4viMS7PBu/uHd6MqooAWj6dY7PTTmREP4uHs Z0BsRbfLZ/Jw4Thh49hIpGkdR1L9DtrHC0ikWV3nZYAVmPNdzmC2B1QJEAmc0MynEhxb kMPALwdfhrKrppIGmElEMhKz450LdZEkT3sRpw980ENuRacLHX8HF0bh3oMqDk1huwqB wiNw== X-Gm-Message-State: ALoCoQnrib5vMoH8OVocypEzBQrgdwl6go/tJa40Izbnz3gBnXILmE3JYbKsTw8gEs0QXY5dlOYx X-Received: by 10.180.74.237 with SMTP id x13mr852422wiv.6.1413924856515; Tue, 21 Oct 2014 13:54:16 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id c5sm16071098wje.30.2014.10.21.13.54.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 13:54:15 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Tue, 21 Oct 2014 22:53:59 +0200 Message-ID: <4337777.fZJZ2Jprv9@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1411634427-746-5-git-send-email-helin.zhang@intel.com> References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <1411634427-746-5-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 20:45:59 -0000 2014-09-25 16:40, Helin Zhang: > To support possible different sizes of redirection table, > structures and functions need to be redefined. In detail, > * 'struct rte_eth_rss_reta' has been redefined. > * 'uint16_t reta_size' has been added into > 'struct rte_eth_dev_info'. > * Updating/querying reta have been reimplemented with one > more parameter of redirection table size. > > v2 changes: > * Put changes for supporting multiple sizes of reta in > ethdev into a single patch. In order to allow usage of git bisect, compilation must not be broken, even inside a patchset. So when refactoring an existing API, you must adapt the dependent code in the same patch. To make things easy to review, please try to change API incrementally with good explanation of why each change is needed. > /* Definitions used for redirection table entry size */ > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > -#define ETH_RSS_RETA_MAX_QUEUE 16 > +#define ETH_RSS_RETA_SIZE_64 64 > +#define ETH_RSS_RETA_SIZE_128 128 > +#define ETH_RSS_RETA_SIZE_512 512 > + > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) Are these constants really needed? > /** > - * A structure used to configure Redirection Table of the Receive Side > - * Scaling (RSS) feature of an Ethernet port. > + * A structure used to configure 64 entries of Redirection Table of the > + * Receive Side Scaling (RSS) feature of an Ethernet port. To configure > + * more than 64 entries supported by hardware, an array of this structure > + * is needed. > */ Explaining the array of 64 entries could be useful in commit log. Please don't forget to answer the "why" question in commit logs. Thanks -- Thomas