From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0083.outbound.protection.outlook.com [104.47.33.83]) by dpdk.org (Postfix) with ESMTP id 901067CDE for ; Fri, 22 Sep 2017 08:24:16 +0200 (CEST) Received: from CY4PR03CA0106.namprd03.prod.outlook.com (2603:10b6:910:4d::47) by SN2PR03MB2366.namprd03.prod.outlook.com (2603:10b6:804:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 22 Sep 2017 06:24:15 +0000 Received: from BY2FFO11FD032.protection.gbl (2a01:111:f400:7c0c::132) by CY4PR03CA0106.outlook.office365.com (2603:10b6:910:4d::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Fri, 22 Sep 2017 06:24:15 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD032.mail.protection.outlook.com (10.1.14.210) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Fri, 22 Sep 2017 06:24:15 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8M6OCum025614; Thu, 21 Sep 2017 23:24:12 -0700 To: Thomas Monjalon CC: , , References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170823141213.25476-21-shreyansh.jain@nxp.com> <10181677.XQAPLOLpmf@xps> From: Shreyansh Jain Message-ID: <433901bb-6f1d-ad3e-2720-07392c2d0c04@nxp.com> Date: Fri, 22 Sep 2017 12:05:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <10181677.XQAPLOLpmf@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131505350554287702; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(39380400002)(39860400002)(376002)(346002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(377454003)(189002)(65956001)(33646002)(81156014)(8676002)(81166006)(65826007)(54356999)(5660300001)(6666003)(316002)(85426001)(104016004)(31696002)(230700001)(58126008)(77096006)(76176999)(229853002)(6916009)(68736007)(356003)(498600001)(54906003)(2950100002)(86362001)(189998001)(64126003)(6246003)(53936002)(4326008)(105606002)(97736004)(23676002)(305945005)(106466001)(50466002)(83506001)(47776003)(65806001)(8936002)(31686004)(36756003)(8656003)(2906002)(93886005)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2366; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD032; 1:2z+7DUDq3/TlW4B+ps7UnrA+cUpUI8NMNgHbcmoa7GUEtOBjvjwHb2px2OTypYgmnDtd0MFP6M5JPOZJcX47Rpo0AgvCu9iMTbrx5bCg/deOfh3yeN19+f3OXRsJP3i2 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90caac07-eb7d-4c57-fe56-08d501828c50 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN2PR03MB2366; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 3:6teKP2GGxySENN315j8aPjtsaxf6JVyCZnvYf+eCA6d2JV5oWJKHYKwq93xKDTUuWN46e5Y4JEdf3TDo7KoZDvoEaSqtb62O8z93b2zErhvyRQjH/HvGqywv2LUgGjGaalrUzjVhnoa6hXzIrrGpHIjShxehFQJKrwpSXwp96OCEx78TFgqZAi87QzADD7ptuzn/45mWPrSWAXpbjqKMiPEQXfkxwfwfjvzd9j1RCr6ut+vfV/5DSnGKiqRDAIWXLMIbmbjmACcjAi8uNIzC2pfJTvPqsPTpA00Alhqzg4exTGqWlvlKmML2RBuj2aQ865bwcEeOl0BkNnv10LdXyKkleYrEseD/FweuKAvzA7Y=; 25:73BioWKbVhxG+tvwK1cswKU3+Aa0J0iVQa+rxcZJDsKN2AivFjSbyWf+pR6/7Mw/GL2H6damEEarM/J/0fIj6q7TefjZe58HAZtkUlL/X8VXt4J7yQUhDS/8feF0bJAcJj3IcQFVl0Kt6lYXZSayoiqr24u/Ut/+2PaQJLlOFMVrxfiUU6Ca5zfNHUj5ot8fm7anz4gJPCn2i4P0KBEg9iR69TVc31jRCplu3Z6dDS9+pUP7aynhdt/yQ3aZr6PioC4caS1IdESitPLXRlH6DEGablgr5BLOm9p9Pl8ai1ryxaVnqHU0hu1emwMuS4Xr+s0HT4DEZ9rEIfotcgpGPg== X-MS-TrafficTypeDiagnostic: SN2PR03MB2366: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 31:hbfSVSe1765a5/ctO3VwY5JI5xWQYUmBUZvJfiap7vp/DIAmiekRgAmnsfM31mmnG3TDO055pVCuNrjj8zwbEWpxZ9+z1iylbD9vtMTfM64auiVOQ3DzzoXeTJSWQlm5ixcFqGml0l8aMiM6FmqOiBgLiWTu/mf+EeP7mDOqAhDHtMdNl7R6PXeX/TuzQvdqgVA9wMGiqw0WgvDlxpNryHjoZRMiZvowTSHGoCwOzwo=; 4:3UzVpjSyxvPGTTdoUmHu9e11Wj2wXKwwWxq5PpP6q/9ZL7oVLXlrkqxE1g5YKvlhfAoJYzIFmnVy9L0A3BzRpXMZat9hPmU+6csZeuIumPbSy0fMkz+OtWNbnCdht6U1BK9d9pLRMuQUEFXSu6vKxSJgsBcR85OQ4rYeTTPxdWzC/DbqonUeieHNVJBSkPjufmNm+WphHzCFqjA2kVslWGOzxNNdgIRcdsx02Xp6smXQZnldAa63zs097dT0C/sy X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123559100)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123556025)(20161123565025)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR03MB2366; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR03MB2366; X-Forefront-PRVS: 0438F90F17 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIyMzY2OzIzOnRjZnVZSzJrL1V4emEwWjZ2Y2NBZEM2M1pv?= =?utf-8?B?L1Y4OVhDVjNUVERTNGFKL2hGcWY5NUJLd0NkaHhMZEFBMVprUWFuTXRqVzRE?= =?utf-8?B?M1ZRcVJFcWFjTnN5MGNkSWpZaVlINThCRFRPMkNYNnNyRXpKTlZwQlN0SXNT?= =?utf-8?B?VVhvRlZRcVF2cnc1bjZDT1JudXRlSzhuTzRHVzFPSnV3dW5KdjgxN1BJdUxY?= =?utf-8?B?ajA0Q2RHUE1HelFYbkRzMGRidVB4V1ZRVzJzWDVNbGRXMkZvTy9TUEc1UGho?= =?utf-8?B?QW9KcGgyOXBEZXVBMGp2Qmdoamxvam1CNmcyeS9tdVBYUXJ3LzNuRGNHZWds?= =?utf-8?B?bWhRTHFleHhubUlrZWFBNlRia2NuOTRQZkIxTlpaeDRjWEFIclVwdklHTHk2?= =?utf-8?B?UVg0Rm9tNDhjQXBqcndjcGpSeDVSM0RRNXp4eWJrNEpaRTZ1S3gxc3Uzbnd0?= =?utf-8?B?RU1IMERiMlczbmt6WHYrcmlBZ0F0My9XZG00NmVFN0RHSzVwL3grQjR1OGxi?= =?utf-8?B?aHMvaUI5TS9naVloMXU4K2hsVFgyLzdiakx1ODFXcEJheDNXUzF2SkIvcGVB?= =?utf-8?B?ZkV2UlpDWVp2TTJYUmlZSHVZS2pIbTJrWVdvQUFSbHBTWDBKSVZEUElLN3E3?= =?utf-8?B?OXZyUy9GVVl0emNqMGNpbWFmcldpM1czaW4zd1dXTXo2cWtPaHZPQUdvSmkw?= =?utf-8?B?MWdFVitaalFxbm5lMm5IaWlPamFpTnJSdEs1dklHZlFuczdacTJxZVArYjh4?= =?utf-8?B?eTdGOWdJUEp1N3RrTFprUSt5Tk9vc255V0dMSklzUlB2OFJKUEFsVXZOZ1NX?= =?utf-8?B?SkM1enJIOHd1RXJucENsUWw1S0ZBY2VSWE0zYW9MRnRuVjViNjdYajh3aFkw?= =?utf-8?B?dHRxb3FGSTR0dFZ0UjNwRi85UkMrQnBvNmllc3loek8wanl2V2ZzdjZ4VGw5?= =?utf-8?B?ZVkxMk05ZUx2UXIzRlRCWElkblFLN3E2eHowL2dGYjgvcC9RUVdXN09tNDVK?= =?utf-8?B?bFJHaUl0YVJtQ0p1clJhV1BGRVQ1RWJ4YkNsdjFqRnJCZmdId1N0ZVFwbnhP?= =?utf-8?B?eGJYUkRlUFQ0TjNXK1h0cUJqSVBjNUxnMURQMjVtN2hXbGhqazZyUW9EM080?= =?utf-8?B?a3JKZkFkZnVXcUNrOEw5dTR5S3J4WExjbjRMMlIrUWpYMnpZVkJVWVR5bklr?= =?utf-8?B?cE84dXNwWGRjNHpZTWFLcEN6N3NXUy9pWXYvdFg0RUh1T0xBWkJTL0pzdUp0?= =?utf-8?B?N3ZhcFhiS05TbEFneURaNVpTeVpIS3ZGRVd6TkhhMEx0N1lNdUF3emMwelBU?= =?utf-8?B?cWZ1MG9BTUNqSmY3UXJMV2pHc25CTEphVHo1WmpVbE5Ma0lyeElIVDV5QW1N?= =?utf-8?B?cXNpQWs0VFNQMS9zcVBaOUtmK1lIdWdtejdnUjRCKzRFTUZLL1Qraktjd2t1?= =?utf-8?B?M3pOSDgzaGlydkErc2N2Sm9RLyt3STlrVXYrVjBvMnIrMHptUFlMdXB0eVFu?= =?utf-8?B?U1RXTWk2Q2FNY1pwdVoza0hLYUcycDIveHN1NndmUzhFM2lvTEE1cnprU28w?= =?utf-8?B?ajZjaDlQWmNFMFhGbXEvaytEV21nNDlJT1NoQkQwWXVGQ0lYWEtpUGVTeXky?= =?utf-8?B?TUhxTlZBWnAzSTVVdThHRXUyNmJXWlpEYTY0UnRaQ0FzWkFXUjM4d2JhUmtm?= =?utf-8?B?dEk4S0VhZDRweFZ4ZXo3ZU5udEI5c1ZaNk45ZEZVMkVNWi93RU05aVFpbkZ4?= =?utf-8?B?UTNUZVZwUjZ5QkxEM1dVbTZ2c2pHWXZUQThERVdkbVRrVHlhUGU0dFo3aTdX?= =?utf-8?B?UDAydk5DbW04N0k0ZkVlbHRDdW1BOGVhNmltNDJvQ01UOEx0T0NWSjRNZm4x?= =?utf-8?B?RFliYnkyNFZTMGdHY0JGZDhLeVNqQXZxUFRPSkVSK05mTjZYU3U4Yzc3TFI5?= =?utf-8?B?V2IvSHNQQmJnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 6:TZUrMgKpKjLJp5638b8xye9pwSszsGX5QCaxdTQwluJ7uonjiq/LyhNGP53FpmHfI8SSDafcsUGOlMJZ+SY7D3Uo4DLFn/8tIWajwm99zX2rk5kKhFl8m3dv737ifsYlMaOQcrzrLZQbgFPLx6U5XeJF+6x8QG7lxp9ab8yz69zut612FvBSB8R3VzCMGeLqkP+Z0rqD1VCtkR/dPA3EYNpjgiTSSslYCFNOO8manSt/76SbQqfeAb9CpQNcOHg75G8unSbz5Bwqu7uqdUMe8tOZ1Bxqgopk7KKs0bJQtRX0Bc7KihVsTe7/VPMR/4xAW7mZrSDBk4RKDI2daNVgCQ==; 5:SJp/cXJ2qrsCVJLUoHvrCVfQx05bVqCNr9yWWRNiIR7d+IXO5uZ8IF0/0cF+TqC1baAl9N1pWnTFqnD5k5k9GZ0itOVHeQBY7G62xfMJaqlA0cmyZSJhdFgngPyhdrADkI2sLRWDJNJjjjnXWkACyA==; 24:siF+156tIs1s5KbKUMKxBKAylq9MlXNuf68iCqHoyMgcWqyieQ5IDDHGgUvmRTydK0SnI1LDRrApLcMJWQmYTLTqsYJxDHlkv0OfSuuAuyU=; 7:rPBDA9CLSD7oXi9kqi+C+s4V3ScCG4GF3eJmXo2gpbM6NvfLRrs6sm+eBjbZ7KZhicWT7e2zERKj3iIE9fLHuRu7a/ofNgRRW3790JHo6CzdRJF7xPeYn7ZJZ1ZzcGVej6p704tN05XXmoUlnvHdbR1uDDHDlQJGz9DqhCLhDn7eyjkev8E0Vvl5RkgnQSKO4sZx6evw9Vng63tFHRDqea5eYTS8DGGH63TORfZFRVg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2017 06:24:15.2259 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2366 Subject: Re: [dpdk-dev] [PATCH v3 20/40] drivers: enable compilation of DPAA Mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 06:24:17 -0000 On Friday 22 September 2017 03:25 AM, Thomas Monjalon wrote: > 23/08/2017 16:11, Shreyansh Jain: >> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n > > Please could you try to remove this kind of option? > We are going to remove them from DPDK. OK. I will revisit and remove which are not impacting the performance. > > For control path, no need of removing logs at compilation time. > For data path, compilation of logs is controlled by CONFIG_RTE_LOG_DP_LEVEL. > For enabling/disabling logs at runtime in the component, > there is the dynamic log types. > I had already introduced dynamic log types for DPAA1. There weren't much examples for me to identify 'best practice'. I preferred this toggling so that I can be clear about when debugging is truly disabled.