From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4C9B05582 for ; Tue, 6 Dec 2016 20:50:29 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 06 Dec 2016 11:50:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="1078335777" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2016 11:50:27 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-33-git-send-email-hemant.agrawal@nxp.com> Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com From: Ferruh Yigit Message-ID: <434169e4-1f69-714d-8a68-07bf66dc3a79@intel.com> Date: Tue, 6 Dec 2016 19:50:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480875447-23680-33-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 32/32] net/dpaa2: enable stashing for LS2088A devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 19:50:29 -0000 On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal Not just specific to this patch, but overall, can you please try to provide more information in the comment logs. > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index 1a25f07..dd8e8fb 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -229,6 +229,17 @@ > options = options | DPNI_QUEUE_OPT_USER_CTX; > cfg.user_context = (uint64_t)(dpaa2_q); > > + /*if ls2088 or rev2 device, enable the stashing */ > + if ((qbman_get_version() & 0xFFFF0000) > QMAN_REV_4000) { > + options |= DPNI_QUEUE_OPT_FLC; > + cfg.flc.stash_control = true; > + cfg.flc.value &= 0xFFFFFFFFFFFFFFC0; > + /* 00 00 00 - last 6 bit represent annotation, context stashing, > + * data stashing setting 01 01 00 (0x14) to enable > + * 1 line annotation, 1 line context > + */ > + cfg.flc.value |= 0x14; > + } > ret = dpni_set_queue(dpni, CMD_PRI_LOW, priv->token, DPNI_QUEUE_RX, > dpaa2_q->tc_index, flow_id, options, &cfg); > if (ret) { >