DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Ouyang, Changchun" <changchun.ouyang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue	start/stop
Date: Tue, 22 Jul 2014 09:52:26 +0000	[thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D015ADC4F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2633548.rrHgnQHcZ9@xps13>

Hi Thomas,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 22, 2014 5:38 PM
> To: Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue
> start/stop
> 
> Hi,
> 
> 2014-07-22 15:47, Ouyang Changchun:
> > This patch series include 3 things:
> > 1) Rename the field name from start_rx_per_q to rx_enable_queue in
> > struct rte_eth_rxconf, and do same thing for TX.
> > This patch also update description for field rx_enable_queue and
> tx_enable_queue.
> > 2) According to 1), update field name from start_rx_per_q to
> rx_enable_queue in struct igb_rx_queue
> >  in ixgbe PMD, do same thing for TX.
> > 3) Update its reference in sample vhost.
> 
> In order to be atomic (and do not break git bisect), you should submit
> it in one patch.
> Title would be "ethdev: rename queue enabler field" or something like that.
> But the most important in such change is to explain why you make it.
> 
> Thanks
> --
> Thomas

The reason adding this patch is that "start_rx_per_q" and "start_tx_per_q" has requirement in NIC driver in some cases. The implication includes:
1. don't fill mbuf address in RX ring in later dev start function call.
2. don't try to switch this rx/tx queues on in later dev start function call.  Instead, application will call rte_eth_dev_rx/tx_queue_start/stop to control
    this queue.

If the NIC driver tried to support these 2 options, it will have to satisfy above 2 conditions. But the problem is that the 2 fields definition don't have
a word to claim on their requirement. So, we needs this patch and add comments. 
As for renaming, it's not so important. Just for better understanding. 



 

  reply	other threads:[~2014-07-22  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  7:47 Ouyang Changchun
2014-07-22  7:47 ` [dpdk-dev] [PATCH 1/3] ether: Update field name and description for queue start Ouyang Changchun
2014-07-22 17:43   ` Stephen Hemminger
2014-07-22  7:47 ` [dpdk-dev] [PATCH 2/3] ixgbe: Rename field name for queue start in ixgbe PMD Ouyang Changchun
2014-07-22  7:47 ` [dpdk-dev] [PATCH 3/3] vhost: Update reference in user space vhost sample Ouyang Changchun
2014-07-22  9:37 ` [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop Thomas Monjalon
2014-07-22  9:52   ` Chen, Jing D [this message]
2014-07-23  1:07     ` Ouyang, Changchun
2014-07-28  4:34   ` Ouyang, Changchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4341B239C0EFF9468EE453F9E9F4604D015ADC4F@shsmsx102.ccr.corp.intel.com \
    --to=jing.d.chen@intel.com \
    --cc=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).