From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 354697E74 for ; Wed, 15 Oct 2014 08:53:18 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 14 Oct 2014 23:51:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,722,1406617200"; d="scan'208";a="605585233" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 15 Oct 2014 00:01:04 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 00:01:05 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 00:01:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.172]) with mapi id 14.03.0195.001; Wed, 15 Oct 2014 15:01:03 +0800 From: "Chen, Jing D" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement Thread-Index: AQHP1zBXpINK7wOEJkO7ZMHxDR5/NZwvQM0AgAGcA/A= Date: Wed, 15 Oct 2014 07:01:02 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D015F3618@shsmsx102.ccr.corp.intel.com> References: <1411478047-1251-1-git-send-email-jing.d.chen@intel.com> <1411478047-1251-6-git-send-email-jing.d.chen@intel.com> <1581482.OfWWpU8tO6@xps13> In-Reply-To: <1581482.OfWWpU8tO6@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2014 06:53:18 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 14, 2014 10:25 PM > To: Chen, Jing D > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement >=20 > 2014-09-23 21:14, Chen Jing D: > > + PMD_DRV_LOG(ERR, "VMDQ not %s, can't set mac to > pool %u\n", > > + pf->flags | I40E_FLAG_VMDQ ? "configured" : > "enabled", > > + pool); > [...] > > - if (ret !=3D I40E_SUCCESS) { > > - PMD_DRV_LOG(ERR, "Failed to write mac address"); > > + if (pool > pf->nb_cfg_vmdq_vsi) { > > + PMD_DRV_LOG(ERR, "Pool number %u invalid. Max pool > is %u\n", > > + pool, pf->nb_cfg_vmdq_vsi); > [...] > > - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); > > + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter\n"); > [...] > > + PMD_DRV_LOG(ERR, "Failed to remove > MACVLAN filter\n"); >=20 > I'm pretty sure you rebased this patch and solved the conflicts without > updating your patch accordingly. Indeed carriage returns have been remove= d > from logs recently. > Hint: rebase conflicts are really often meaningful ;) >=20 Thanks for your suggestion. > -- > Thomas