From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 89B8F58EE for ; Tue, 4 Nov 2014 06:42:56 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 03 Nov 2014 21:52:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,311,1413270000"; d="scan'208";a="616601123" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2014 21:52:09 -0800 Received: from kmsmsx152.gar.corp.intel.com (172.21.73.87) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 13:50:33 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 13:50:33 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Tue, 4 Nov 2014 13:50:32 +0800 From: "Chen, Jing D" To: Thomas Monjalon Thread-Topic: [PATCH v2 1/6] ether: enhancement for VMDQ support Thread-Index: AQHP6SkQ7dwWnpxCmEi694PtWyB/AZxPD1uAgAECIcA= Date: Tue, 4 Nov 2014 05:50:32 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D016061A7@shsmsx102.ccr.corp.intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <1413454046-13407-1-git-send-email-jing.d.chen@intel.com> <1413454046-13407-2-git-send-email-jing.d.chen@intel.com> <48821528.yaSnYYWibr@xps13> In-Reply-To: <48821528.yaSnYYWibr@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/6] ether: enhancement for VMDQ support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 05:42:57 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, November 04, 2014 6:17 AM > To: Chen, Jing D > Cc: dev@dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support >=20 > 2014-10-16 18:07, Chen Jing D: > > /** > > + * Simple flags to indicate RX mq mode, which can be used independent= ly > or combined > > + * in enum rte_eth_rx_mq_mode definition. > > + */ > > +#define ETH_MQ_RX_RSS_FLAG 0x1 > > +#define ETH_MQ_RX_DCB_FLAG 0x2 > > +#define ETH_MQ_RX_VMDQ_FLAG 0x4 >=20 > The comment would be more useful by explaining that these flags are used > for rte_eth_conf.rxmode.mq_mode. Yes, that's more straightforward.=20 >=20 > > + /**< None of DCB,RSS or VMDQ mode */ > > + ETH_MQ_RX_NONE =3D 0, > > + > > + /**< For RX side, only RSS is on */ > > + ETH_MQ_RX_RSS =3D ETH_MQ_RX_RSS_FLAG, > > + /**< For RX side,only DCB is on. */ > > + ETH_MQ_RX_DCB =3D ETH_MQ_RX_DCB_FLAG, > > + /**< Both DCB and RSS enable */ > > + ETH_MQ_RX_DCB_RSS =3D ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_DCB_FLAG, > > + > > + /**< Only VMDQ, no RSS nor DCB */ > > + ETH_MQ_RX_VMDQ_ONLY =3D ETH_MQ_RX_VMDQ_FLAG, > > + /**< RSS mode with VMDQ */ > > + ETH_MQ_RX_VMDQ_RSS =3D ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_VMDQ_FLAG, > > + /**< Use VMDQ+DCB to route traffic to queues */ > > + ETH_MQ_RX_VMDQ_DCB =3D ETH_MQ_RX_VMDQ_FLAG | > ETH_MQ_RX_DCB_FLAG, > > + /**< Enable both VMDQ and DCB in VMDq */ > > + ETH_MQ_RX_VMDQ_DCB_RSS =3D ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_DCB_FLAG | > > + ETH_MQ_RX_VMDQ_FLAG, >=20 > Doxygen comments placed before should start with /** not /**<. My mistake. Thanks for pointing it out. >=20 > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > applicable. */ > > + uint16_t vmdq_queue_base; > > + uint16_t vmdq_queue_num; >=20 > Please explain what mean the values in vmdq_queue_base and > vmdq_queue_num. I thinks the name is self- explanatory, I also add some comments for them. = =20 As previous max_rx/tx_queues indicates how many queues available, these=20 2 variables defines the queue ranges for VM usage. =20 What kind of explanations you needs me to add? >=20 > Thanks > -- > Thomas