From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C5E02A9 for ; Tue, 4 Nov 2014 09:54:03 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 04 Nov 2014 01:03:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,312,1413270000"; d="scan'208";a="631004065" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2014 01:03:16 -0800 Received: from pgsmsx106.gar.corp.intel.com (10.221.44.98) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 16:59:53 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by pgsmsx106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 16:59:53 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Tue, 4 Nov 2014 16:59:40 +0800 From: "Chen, Jing D" To: Thomas Monjalon Thread-Topic: [PATCH v2 1/6] ether: enhancement for VMDQ support Thread-Index: AQHP6SkQ7dwWnpxCmEi694PtWyB/AZxPD1uAgAECIcD//6/BgIAAh4GA Date: Tue, 4 Nov 2014 08:59:39 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D016062D1@shsmsx102.ccr.corp.intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <48821528.yaSnYYWibr@xps13> <4341B239C0EFF9468EE453F9E9F4604D016061A7@shsmsx102.ccr.corp.intel.com> <3494957.2Q8m5MX3oE@xps13> In-Reply-To: <3494957.2Q8m5MX3oE@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/6] ether: enhancement for VMDQ support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 08:54:04 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, November 04, 2014 4:54 PM > To: Chen, Jing D > Cc: dev@dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support >=20 > 2014-11-04 05:50, Chen, Jing D: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-16 18:07, Chen Jing D: > > > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > > > applicable. */ > > > > + uint16_t vmdq_queue_base; > > > > + uint16_t vmdq_queue_num; > > > > > > Please explain what mean the values in vmdq_queue_base and > > > vmdq_queue_num. > > > > I thinks the name is self- explanatory, I also add some comments for th= em. > > As previous max_rx/tx_queues indicates how many queues available, > these > > 2 variables defines the queue ranges for VM usage. >=20 > I understand clearly now. >=20 > > What kind of explanations you needs me to add? >=20 > You cannot put a doxygen comment which apply to 2 fields. > Try do describe precisely the meaning of each field. > Example: /**< first queue ID in the range for VMDQ pool */ > and /**< size of the queue range for VMDQ pool */ Thanks! Got you. >=20 > -- > Thomas