From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
Date: Thu, 4 Dec 2014 14:29:15 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0162B469@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2122900.sczHU7BWUg@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, December 4, 2014 6:39 PM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
>
> 2014-12-04 10:30, Chen, Jing D:
> > As I don't know what commit he is based on, I'd like to generate a new
> patch with latest dpdk repo.
>
> There's something wrong here. You rework a patch and you don't know what
> was the current status but you expect that the reviewers can understand it
> better than you?
You don't understand me. Please read my above words again.
As I said, he is in vacation, I came to fix problem. I know exactly what's the problem. So, I used simple way.
> You are breaking all the elementary rules of patch management.
Please kindly list all the elementary rules of patch management, please. If possible, can you post it somewhere so other new guys can find and follow?
> We have currently 2 fixes pending for the same bug.
>
> PS: please don't top post.
I apologized for top post.
>
> --
> Thomas
>
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Thursday, December 04, 2014 6:26 PM
> > > To: Chen, Jing D
> > > Cc: dev@dpdk.org; Qiu, Michael
> > > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
> > >
> > > 2014-12-04 10:18, Qiu, Michael:
> > > > Hi Mark,
> > > >
> > > > I think Huawei (huawei.xie@intel.com) has one patch set to fix this
> issue.
> > > >
> > > > If your patch is totally different with him:
> > > >
> > > > [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix
> > > >
> > > > please ignore my comments :)
> > > >
> > > > But you both calculation are different.
> > >
> > > Yes, please Jing (Mark), if you reworked the v4 patch, it would
> > > clearer to have a changelog, to name it v5 and to insert it in the
> > > previous thread with --in-reply-to.
> > > At the moment, both patches block each other.
> > >
> > > --
> > > Thomas
next prev parent reply other threads:[~2014-12-04 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 9:50 Chen Jing D(Mark)
2014-12-04 10:18 ` Qiu, Michael
2014-12-04 10:25 ` Chen, Jing D
2014-12-04 10:25 ` Thomas Monjalon
2014-12-04 10:30 ` Chen, Jing D
2014-12-04 10:38 ` Thomas Monjalon
2014-12-04 14:29 ` Chen, Jing D [this message]
2014-12-04 15:32 ` Thomas Monjalon
2014-12-05 4:56 ` Xie, Huawei
2014-12-05 9:18 ` Thomas Monjalon
2014-12-05 8:38 ` Chen, Jing D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D0162B469@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).