From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jing.d.chen@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 73FD8376C
 for <dev@dpdk.org>; Mon,  2 Feb 2015 06:37:31 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 01 Feb 2015 21:34:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,504,1418112000"; d="scan'208";a="521155024"
Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82])
 by orsmga003.jf.intel.com with ESMTP; 01 Feb 2015 21:29:59 -0800
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Mon, 2 Feb 2015 13:34:45 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0195.001;
 Mon, 2 Feb 2015 13:34:44 +0800
From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Thread-Topic: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files
Thread-Index: AQHQPErIuHHy5Tg05UC3lptn6sYToJzZvkQAgAMW9JA=
Date: Mon, 2 Feb 2015 05:34:43 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D01661FA5@shsmsx102.ccr.corp.intel.com>
References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com>
 <1422594454-11045-4-git-send-email-jing.d.chen@intel.com>
 <20150131140200.GA22012@localhost.localdomain>
In-Reply-To: <20150131140200.GA22012@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2015 05:37:31 -0000

Hi Neil,

> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Saturday, January 31, 2015 10:02 PM
> To: Chen, Jing D
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files
>=20
> On Fri, Jan 30, 2015 at 01:07:19PM +0800, Chen Jing D(Mark) wrote:
> > From: Jeff Shaw <jeffrey.b.shaw@intel.com>
> >
> > Define macros and basic data structure.
> > Define rte_log wrapper functions.
> >
> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> > ---
> >  lib/librte_pmd_fm10k/Makefile     |   96 ++++++++++++++++
> >  lib/librte_pmd_fm10k/fm10k.h      |  224
> +++++++++++++++++++++++++++++++++++++
> >  lib/librte_pmd_fm10k/fm10k_logs.h |   66 +++++++++++
> >  3 files changed, 386 insertions(+), 0 deletions(-)
> >  create mode 100644 lib/librte_pmd_fm10k/Makefile
> >  create mode 100644 lib/librte_pmd_fm10k/fm10k.h
> >  create mode 100644 lib/librte_pmd_fm10k/fm10k_ethdev.c
> >  create mode 100644 lib/librte_pmd_fm10k/fm10k_logs.h
> >  create mode 100644 lib/librte_pmd_fm10k/fm10k_rxtx.c
> >
> Why are you adding empty files?

The 2 ".c" files are empty while the 2 ".h" files include code. "Makefile" =
includes rules to
compile the ".c" files, I don't like to break the compile for every single =
patch, that's why
the 2 ".c" files are added in this patch.
=20
>=20
> Neil

Thanks for your comments.
Mark