From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CF9C35A53 for ; Tue, 9 Jun 2015 05:27:16 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 08 Jun 2015 20:27:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,577,1427785200"; d="scan'208";a="743376941" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga002.jf.intel.com with ESMTP; 08 Jun 2015 20:27:15 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 9 Jun 2015 11:27:13 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002; Tue, 9 Jun 2015 11:27:12 +0800 From: "Chen, Jing D" To: "He, Shaopeng" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] fm10k: update VLAN offload features Thread-Index: AQHQnOAl2dxj6qWvDUO+tETQHpUBKp2jjktw Date: Tue, 9 Jun 2015 03:27:12 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D016FA28F@shsmsx102.ccr.corp.intel.com> References: <1433213937-21690-1-git-send-email-shaopeng.he@intel.com> <1433213937-21690-4-git-send-email-shaopeng.he@intel.com> In-Reply-To: <1433213937-21690-4-git-send-email-shaopeng.he@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 03:27:17 -0000 Hi, > -----Original Message----- > From: He, Shaopeng > Sent: Tuesday, June 02, 2015 10:59 AM > To: dev@dpdk.org > Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng > Subject: [PATCH 3/3] fm10k: update VLAN offload features >=20 > Fm10k PF/VF does not support QinQ; VLAN strip and filter are always on > for PF/VF ports. >=20 > Signed-off-by: Shaopeng He > --- > drivers/net/fm10k/fm10k_ethdev.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 4f23bf1..9b198a7 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -884,6 +884,27 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, > uint16_t vlan_id, int on) > return (-EIO); > } >=20 > +static void > +fm10k_vlan_offload_set(__rte_unused struct rte_eth_dev *dev, int mask) > +{ > + if (mask & ETH_VLAN_STRIP_MASK) { > + if (!dev->data->dev_conf.rxmode.hw_vlan_strip) > + PMD_INIT_LOG(ERR, "VLAN stripping is " > + "always on in fm10k"); > + } > + > + if (mask & ETH_VLAN_EXTEND_MASK) { > + if (dev->data->dev_conf.rxmode.hw_vlan_extend) > + PMD_INIT_LOG(ERR, "VLAN QinQ is not " > + "supported in fm10k"); > + } > + > + if (mask & ETH_VLAN_FILTER_MASK) { > + if (!dev->data->dev_conf.rxmode.hw_vlan_filter) > + PMD_INIT_LOG(ERR, "VLAN filter is always on in > fm10k"); > + } > +} > + Update fm10k_dev_infos_get() to configure above options to expected values? > /* Add/Remove a MAC address, and update filters */ > static void > fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add) > @@ -1801,6 +1822,7 @@ static const struct eth_dev_ops > fm10k_eth_dev_ops =3D { > .link_update =3D fm10k_link_update, > .dev_infos_get =3D fm10k_dev_infos_get, > .vlan_filter_set =3D fm10k_vlan_filter_set, > + .vlan_offload_set =3D fm10k_vlan_offload_set, > .mac_addr_add =3D fm10k_macaddr_add, > .mac_addr_remove =3D fm10k_macaddr_remove, > .rx_queue_start =3D fm10k_dev_rx_queue_start, > -- > 1.9.3