From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Qiu, Michael" <michael.qiu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fm10K: fix interrupt fault handling
Date: Tue, 21 Jul 2015 07:15:21 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0172404A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1437093202-30265-1-git-send-email-stephen@networkplumber.org>
Hi, Stephen,
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, July 17, 2015 8:33 AM
> To: Qiu, Michael; Chen, Jing D
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] fm10K: fix interrupt fault handling
>
> The fm10k driver was reading the interrupt cause register but then
> using the interrupt mask register defines to look at the bits.
> The result is that if a fault happens, the driver would never clear
> the fault and would get into an infinite cycle of interrupts.
>
> Note: I don't work for Intel or have the hardware manuals (probably
> requires NDA anyway), but this looks logical and matches how the
> known working Linux driver handles these bits.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Good catch! Thanks!
Acked-by: Jing Chen <jing.d.chen@intel.com>
next prev parent reply other threads:[~2015-07-21 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 0:33 Stephen Hemminger
2015-07-21 7:15 ` Chen, Jing D [this message]
2015-07-22 10:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D0172404A@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).