From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C56658E4 for ; Fri, 23 Oct 2015 10:27:41 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 23 Oct 2015 01:27:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,185,1444719600"; d="scan'208";a="817684260" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 23 Oct 2015 01:27:39 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Oct 2015 01:27:39 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Oct 2015 01:27:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.106]) with mapi id 14.03.0248.002; Fri, 23 Oct 2015 16:27:38 +0800 From: "Chen, Jing D" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initialize all parameters Thread-Index: AQHRDK5o1P4U93oN3ESlwXQ1z6Dt9J53JVkAgAGaASA= Date: Fri, 23 Oct 2015 08:27:37 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D02AE28E6@shsmsx102.ccr.corp.intel.com> References: <1443531824-22767-2-git-send-email-jing.d.chen@intel.com> <1445507104-22563-1-git-send-email-jing.d.chen@intel.com> <1445507104-22563-4-git-send-email-jing.d.chen@intel.com> <20151022085754.17478c99@xeon-e3> In-Reply-To: <20151022085754.17478c99@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initialize all parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 08:27:41 -0000 Hi, Stephen, Best Regards, Mark > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, October 22, 2015 11:58 PM > To: Chen, Jing D > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initial= ize > all parameters >=20 > On Thu, 22 Oct 2015 17:44:51 +0800 > "Chen Jing D(Mark)" wrote: >=20 > > +static void > > +fm10k_params_init(struct rte_eth_dev *dev) > > +{ > > + struct fm10k_hw *hw =3D FM10K_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > + struct fm10k_dev_info *info =3D FM10K_DEV_PRIVATE_TO_INFO(dev); > > + /* Inialize bus info. Normally we would call fm10k_get_bus_info(), > but > > + * there is no way to get link status without reading BAR4. Until th= is > > + * works, assume we have maximum bandwidth. > > + * @todo - fix bus info >=20 > Minor nit. I would prefer that DPDK follow current Linux kernel > style which is to always have a blank line after declarations. > This improves readability. >=20 Thanks the comments! I'll change accordingly. > I.e: >=20 > static void > fm10k_params_init(struct rte_eth_dev *dev) > { > struct fm10k_hw *hw =3D FM10K_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct fm10k_dev_info *info =3D FM10K_DEV_PRIVATE_TO_INFO(dev); >=20 > /* Inialize bus info. Normally we would call fm10k_get_bus_info(), > but > * there is no way to get link status without reading BAR4. Until this > * works, assume we have maximum bandwidth. > * @todo - fix bus info