From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8DF438DAC for ; Fri, 30 Oct 2015 04:09:21 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 29 Oct 2015 20:09:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208";a="674776849" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2015 20:09:20 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 20:09:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 20:09:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 11:09:18 +0800 From: "Chen, Jing D" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 00/16] Vector Rx/Tx PMD implementation for fm10k Thread-Index: AQHREiqNEp22dKyeAketAWVWKgpYlZ6BvN4AgADXTICAAMf5IA== Date: Fri, 30 Oct 2015 03:09:17 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D02AE7148@shsmsx102.ccr.corp.intel.com> References: <1445939209-12783-2-git-send-email-jing.d.chen@intel.com> <1446110173-13330-1-git-send-email-jing.d.chen@intel.com> <7206152.Q02RhEFdjn@xps13> In-Reply-To: <7206152.Q02RhEFdjn@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 00/16] Vector Rx/Tx PMD implementation for fm10k X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 03:09:22 -0000 Hi, Thomas, Best Regards, Mark > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 30, 2015 7:13 AM > To: Chen, Jing D > Cc: dev@dpdk.org; Liang, Cunming > Subject: Re: [dpdk-dev] [PATCH v4 00/16] Vector Rx/Tx PMD implementation > for fm10k >=20 > > > Chen Jing D(Mark) (16): > > > fm10k: add new vPMD file > > > fm10k: add vPMD pre-condition check for each RX queue > > > fm10k: Add a new func to initialize all parameters > > > fm10k: add func to re-allocate mbuf for RX ring > > > fm10k: add 2 functions to parse pkt_type and offload flag > > > fm10k: add Vector RX function > > > fm10k: add func to do Vector RX condition check > > > fm10k: add Vector RX scatter function > > > fm10k: add function to decide best RX function > > > fm10k: add func to release mbuf in case Vector RX applied > > > fm10k: add Vector TX function > > > fm10k: use func pointer to reset TX queue and mbuf release > > > fm10k: introduce 2 funcs to reset TX queue and mbuf release > > > fm10k: Add function to decide best TX func > > > fm10k: fix a crash issue in vector RX func > > > doc: release notes update for fm10k Vector PMD > > > > Acked-by: Cunming Liang >=20 > Sorry, there are some checkpatch warnings and a compilation error: >=20 > SPACING: No space is necessary after a cast > SPACING: spaces preferred around that '+' > LINE_CONTINUATIONS: Avoid unnecessary line continuations >=20 > And more important, with clang: >=20 > fm10k_rxtx_vec.c:69:1: error: unused function 'fm10k_rxq_rearm' Thanks for the comments. I'll fix it.