From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jing.d.chen@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 426C3374C
 for <dev@dpdk.org>; Wed, 25 Nov 2015 09:47:51 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 25 Nov 2015 00:47:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,342,1444719600"; d="scan'208";a="828622917"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 25 Nov 2015 00:47:51 -0800
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 25 Nov 2015 00:47:49 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 25 Nov 2015 00:47:49 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.42]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.83]) with mapi id 14.03.0248.002;
 Wed, 25 Nov 2015 16:47:47 +0800
From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
Thread-Index: AQHRJn124r/9hXcAnEuAH56nEqZM4Z6qc9MAgABnKICAAZPJsA==
Date: Wed, 25 Nov 2015 08:47:47 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D02B0D7D1@shsmsx102.ccr.corp.intel.com>
References: <1448344809-10054-1-git-send-email-jing.d.chen@intel.com>
 <3370349.k1ZE1aKLyK@xps13> <20151124084159.57bae59d@xeon-e3>
In-Reply-To: <20151124084159.57bae59d@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2015 08:47:51 -0000


> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, November 25, 2015 12:42 AM
> To: Thomas Monjalon
> Cc: Chen, Jing D; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx fu=
nc
>=20
> On Tue, 24 Nov 2015 11:32:46 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>=20
> > 2015-11-24 14:00, Chen Jing D:
> > > This patch adds debug info to notify user what actual Rx/Tx
> > > func are used.
> > [...]
> > > +	if (rx_using_sse)
> > > +		PMD_INIT_LOG(ERR, "Use vector Rx func");
> > > +	else
> > > +		PMD_INIT_LOG(ERR, "Use regular Rx func");
> >
> > debug info !=3D LOG(ERR
>=20
> Really should be DEBUG.
> Developers need to remember you don't wan to see those log messages
> in a production system.

Thanks for the comments. I'll change accordingly.=20