From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BC9EC3005 for ; Wed, 3 Feb 2016 08:18:47 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 02 Feb 2016 23:18:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,388,1449561600"; d="scan'208";a="646343750" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 02 Feb 2016 23:18:31 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 23:18:31 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 23:18:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0248.002; Wed, 3 Feb 2016 15:18:29 +0800 From: "Chen, Jing D" To: "He, Shaopeng" , "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: enable PCIe port level Loopback Suppression Thread-Index: AQHRWY+WFdedi9YDLUatI5WiOYVc5p8Z7l+w Date: Wed, 3 Feb 2016 07:18:28 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0443C0A1@shsmsx102.ccr.corp.intel.com> References: <1453960119-31558-1-git-send-email-shaopeng.he@intel.com> In-Reply-To: <1453960119-31558-1-git-send-email-shaopeng.he@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: enable PCIe port level Loopback Suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 07:18:48 -0000 Hi, Best Regards, Mark > -----Original Message----- > From: He, Shaopeng > Sent: Thursday, January 28, 2016 1:49 PM > To: dev@dpdk.org > Cc: Chen, Jing D; Wang, Xiao W; He, Shaopeng > Subject: [PATCH] fm10k: enable PCIe port level Loopback Suppression >=20 > A PCIe port may represent within it multiple logical ports > (for example when SR-IOV is enabled, or when a VMDQ type logical > port scheme is employed assigning ports to sets of queues). > For this reason each RX queue in each PCIe port is given a source > GLORT that is used for loopback suppression. > This patch assigns a SGLORT for each RX queue, and enables PCIe > port level Loopback Suppression. >=20 The log message is a little obscure for me. Maybe you can wrote: In FM10K, a single PF device can derive out a few logical ports, like SRIOV VF device, VMDQ object. To better manage them, FM10K silicon assigned a Unique GLORT ID to each logical ports.=20 When a logical port sends a broadcast packet, the silicon will flood it to = all Logical ports, including the one sent the broadcast packet. To prevent this= , silicon has a rxq register to fill the glort id of the logical port that qu= eue binds=20 to.... > Signed-off-by: Shaopeng He > --- > drivers/net/fm10k/fm10k_ethdev.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index f6eb05d..60f821a 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -690,12 +690,15 @@ static int > fm10k_dev_rx_init(struct rte_eth_dev *dev)