From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D8B045323 for ; Tue, 16 Feb 2016 16:34:31 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 16 Feb 2016 07:34:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="913442064" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 16 Feb 2016 07:34:30 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 16 Feb 2016 07:34:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Tue, 16 Feb 2016 23:34:28 +0800 From: "Chen, Jing D" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func Thread-Index: AQHRWbDArEuEk7azBE+/8a+jQFwPHJ8uY6GAgACG3UA= Date: Tue, 16 Feb 2016 15:34:28 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D04441F9B@shsmsx102.ccr.corp.intel.com> References: <1453974359-20895-1-git-send-email-jing.d.chen@intel.com> <20160216152735.GA13784@bricha3-MOBL3> In-Reply-To: <20160216152735.GA13784@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJmNDJmYmYtMGI4Zi00YjNmLWFkOGQtN2FmMWNlN2E4NmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTFwvbnZvT09CTlRHd0RpTnk1K1NuWW1EWEJcL3NJYkRVd0NXdjdBeFwvMHFLVT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 15:34:32 -0000 Hi, Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 16, 2016 11:28 PM > To: Chen, Jing D > Cc: Qiu, Michael; Ananyev, Konstantin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func >=20 > On Thu, Jan 28, 2016 at 05:45:59PM +0800, Chen Jing D(Mark) wrote: > > From: "Chen Jing D(Mark)" > > > > When legacy TX func tries to free a bunch of mbufs, it will free them > > one by one. This change will scan the free list and merge the requests > > in case they belongs to same pool, then free once, which will reduce > > cycles on freeing mbufs. > > > > Signed-off-by: Chen Jing D(Mark) > > --- > > doc/guides/rel_notes/release_2_3.rst | 2 + > > drivers/net/fm10k/fm10k_rxtx.c | 59 > ++++++++++++++++++++++++++++----- > > 2 files changed, 52 insertions(+), 9 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_2_3.rst > > b/doc/guides/rel_notes/release_2_3.rst > > index 99de186..20ce78d 100644 > > --- a/doc/guides/rel_notes/release_2_3.rst > > +++ b/doc/guides/rel_notes/release_2_3.rst > > @@ -3,7 +3,9 @@ DPDK Release 2.3 > > > > New Features > > ------------ > > +* **Optimize fm10k Tx func.** > > > > + * Free multiple mbufs at a time to reduce freeing mbuf cycles. > > >=20 > Is this really a significant enough change to warrant being called out in= the > release notes? > Personally, I don't think so, so if you are ok with it, I'll just apply t= his patch > without the RN update. >=20 > /Bruce This change will have some performance gain with legacy TX func. That's why I'd like to add a line in release notes. If you thinks it's not necessary, please kindly remove it.