From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D97CDE6D for ; Tue, 8 Mar 2016 15:25:31 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 08 Mar 2016 06:25:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,556,1449561600"; d="scan'208";a="665837969" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 08 Mar 2016 06:25:30 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Mar 2016 06:25:30 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Mar 2016 06:25:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Tue, 8 Mar 2016 22:25:28 +0800 From: "Chen, Jing D" To: "Wang, Xiao W" , "Richardson, Bruce" Thread-Topic: [PATCH v3 00/18] fm10k: update shared code Thread-Index: AQHRawXClIRKu9OwiUKKA+1oAZeGI59PH2kAgAAOQACAAIc1EA== Date: Tue, 8 Mar 2016 14:25:27 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D04457344@shsmsx102.ccr.corp.intel.com> References: <1453866647-16215-2-git-send-email-xiao.w.wang@intel.com> <1455880025-6912-1-git-send-email-xiao.w.wang@intel.com> <20160308132403.GC8716@bricha3-MOBL3> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTE3ZjkxZGItMDc5ZC00ZDQ0LWJkMmUtNjRjMDBmMzIwODM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjlIWFFtbjhmMHBzbWtvRXltakpENGJYTW51bDhEd1BwTVRpUXpDUkJHeG89In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 14:25:33 -0000 Hi, Xiao > -----Original Message----- > From: Wang, Xiao W > Sent: Tuesday, March 8, 2016 8:15 AM > To: Richardson, Bruce ; Chen, Jing D > > Cc: Chen, Jing D ; dev@dpdk.org; He, Shaopeng > > Subject: RE: [PATCH v3 00/18] fm10k: update shared code >=20 >=20 >=20 > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Tuesday, March 8, 2016 9:24 PM > > To: Wang, Xiao W ; Chen, Jing D > > > > Cc: Chen, Jing D ; dev@dpdk.org; He, Shaopeng > > > > Subject: Re: [PATCH v3 00/18] fm10k: update shared code > > > > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote: > > > v3: > > > * Fixed checkpatch.pl warning about long commit message. > > > * Fixed the issue of compile failure about part of patches applied. > > > * Split the misc-small-fixes patch into several patches. > > > > > > v2: > > > * Put the two extra fix patches ahead of the base code patches. > > > > > > This patch set has passed regression test. > > > > > > Wang Xiao W (18): > > > fm10k: use default mailbox message handler for PF > > > fm10k/base: correct typecast in fm10k_update_xc_addr_pf > > > fm10k/base: cleanup namespace pollution > > > fm10k/base: use bitshift for itr_scale > > > fm10k/base: reset max_queues on init_hw_vf failure > > > fm10k/base: document ITR scale workaround in VF TDLEN register > > > fm10k/base: cleanup lines over 80 characters > > > fm10k/base: cleanup useless else > > > fm10k/base: use BIT macro instead of open-coded bit-shifting of 1 > > > fm10k/base: do not use CamelCase > > > fm10k/base: use memcpy for mac addr copy > > > fm10k/base: allow removal of is_slot_appropriate function > > > fm10k/base: consistently use VLAN ID when referencing vid variables > > > fm10k/base: imporve comment per upstream review changes > > > fm10k/base: fix TLV structures alignment > > > fm10k/base: move constants to the right of binary operators > > > fm10k/base: minor cleanups > > > fm10k/base: remove unused struct element > > > > > > drivers/net/fm10k/base/fm10k_api.c | 2 + > > > drivers/net/fm10k/base/fm10k_api.h | 2 + > > > drivers/net/fm10k/base/fm10k_mbx.c | 63 +++++++----- > > > drivers/net/fm10k/base/fm10k_mbx.h | 11 +-- > > > drivers/net/fm10k/base/fm10k_osdep.h | 32 ++++++ > > > drivers/net/fm10k/base/fm10k_pf.c | 88 +++++++++-------- > > > drivers/net/fm10k/base/fm10k_pf.h | 18 ++-- > > > drivers/net/fm10k/base/fm10k_tlv.c | 40 ++++---- > > > drivers/net/fm10k/base/fm10k_tlv.h | 9 +- > > > drivers/net/fm10k/base/fm10k_type.h | 182 +++++++------------------= --- > ------- > > > drivers/net/fm10k/base/fm10k_vf.c | 32 ++++-- > > > drivers/net/fm10k/fm10k_ethdev.c | 41 +++----- > > > 12 files changed, 222 insertions(+), 298 deletions(-) > > > > > > -- > > > 1.9.3 > > > > > Hi Mark, > > > > Can we get fm10k maintainer review and/or ack on this patchset please. > > > > Thanks, > > /Bruce >=20 > Hi Bruce, >=20 > Mark has reviewed and acked the patch set in v2, and I put the "Acked-by = " > in the v3 01/18 patch. > It's the same for my FTAG patch. >=20 It's better to add acked-by in both patch set and cover letter, this may be= more helpful for maintainers.=20 > Best Regards, > Xiao