From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 380EB8E76 for ; Thu, 31 Mar 2016 16:16:25 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 31 Mar 2016 07:15:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,422,1455004800"; d="scan'208";a="948835248" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 31 Mar 2016 07:15:20 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 31 Mar 2016 07:15:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 31 Mar 2016 07:15:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Thu, 31 Mar 2016 22:15:18 +0800 From: "Chen, Jing D" To: Thomas Monjalon , "dev@dpdk.org" CC: Michael Frasca Thread-Topic: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization Thread-Index: AQHRhFwMr7xmNRmhZEecE+5QpXRtrZ9mWouQgAAqWACAAZ/mwIAAM4oAgArDRYCAAImHsA== Date: Thu, 31 Mar 2016 14:15:18 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0446A97F@shsmsx102.ccr.corp.intel.com> References: <1458665888-4577-1-git-send-email-michael.frasca@oracle.com> <4341B239C0EFF9468EE453F9E9F4604D04465361@shsmsx102.ccr.corp.intel.com> <06A5CC0C-D767-48CD-B82D-C4C81AD282AE@oracle.com> <1734643.Kgakri6QQ3@xps13> In-Reply-To: <1734643.Kgakri6QQ3@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJlYWMxMTYtMmY3OC00NGJlLWFmOTUtMWI2MDE0NzI1Mzk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNnSmJLMzE3amNqYnpOMzlPaG01YUpmM01JenBYeE5Bck81VnpNaGE0Y2s9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 14:16:25 -0000 Thomas, We've agreed offline that the patch works without side effect. Please kindly apply if possible. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, March 31, 2016 9:57 PM > To: dev@dpdk.org > Cc: Michael Frasca ; Chen, Jing D > > Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during > device initialization >=20 > Please, anyone to confirm that the patch is valid and must be applied? > This discussion shows some doubts. >=20 >=20 > 2016-03-24 13:35, Michael Frasca: > > Jing, > > > > Thanks for your assistance. The experiment that you have built should > > allow you to observe the bug. In [5], I would expect that queue 0 > > receives roughly 1/4 of the packets that you sending, assuming the > > input packets have varied IP addresses. Can you measure what % of > > packets are actually being received in this single queue setup (after f= irst > running a 4-queue setup)? > > > > When trying to running with only one RX queue, the fm10k retains the > > same RSS hash function and redirection table that was configured from > > a previous run. As a result, some packets are still being directed to > > other receive queues. I have confirmed this by polling the queue > > specific stats, which I retrieved via rte_eth_xstats_get(). > > > > Looking at fm10k_dev_rss_configure(), one should see that there is no > > modification of fm10k registers when nb_rx_queues =3D=3D 1. As far as I > > can tell, this is the reason that only a certain partition of packets > > are being receive in a single queue setup (after first running a multi-= queue > configuration). > > > > I am unable to access my development environment today, but if you > > need, I can later craft a patch to l3fwd that shows the measurement of > > packets received at each queue. > > > > Thanks, > > Mike > > > > > > > On Mar 24, 2016, at 2:40 AM, Chen, Jing D wro= te: > > > > > > Hi, Frasca, > > > > > > > > > > > >> -----Original Message----- > > >> From: Michael Frasca [mailto:michael.frasca@oracle.com > > >> ] > > >> Sent: Wednesday, March 23, 2016 9:43 PM > > >> To: Chen, Jing D > > >> Cc: dev@dpdk.org > > >> Subject: Re: [PATCH] fm10k: conditionally disable RSS during device > > >> initialization > > >> > > >> Hi Jing, > > >> > > >> I ran into this issue while trying to run experiments with > > >> different RSS configurations (no RSS being one cases). It is not > > >> clear to me that setting this register to zero is the best way to di= sable > RSS. > > >> > > >> After digging further, I have a theory that I'm having this issues > > >> because I've only attached my DPDK application to SR-IOV ports. In > > >> fm10k_dev_dglort_map_configure(), I see that 'RSS Length' is set > > >> for the DGLORT decoder. However, it appears that this is only > > >> invoked for physical functions. > > >> > > >> Could this be my problem? Is it required that I bind to the > > >> physical function if I want to properly manipulate RSS? > > >> > > >> Thanks, > > >> Mike > > >> > > > I don't know exactly what problem you ran into. I think we needn't > > > worry about those DGLORT setting when using VF device. > > > > > > I've followed steps to use SRIOV device with RSS enabled and > > > disabled, both are worked well from my side after applying your patch= . > Below is my setup. > > > > > > 1. PF with Linux driver "fm10k-next_0.19.3". > > > 2. DPDK with latest code from master branch, apply your patch. > > > 3. Use 1 VF device created by kernel driver. > > > 4. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1= -- > config=3D"(0,0,2),(0,1,2),(0,2,3),(0,3,3)"" > > > with RSS enabled. After sending packets, I can see all 4 queues re= ceived > packets. > > > 5. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1= -- > config=3D"(0,0,2)"" > > > with RSS disabled. After sending packets, I can see queue 0 receiv= ed > packets. > > > > > > Can you explain what actual problem is? > > > We can talk offline. > > >=20