Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic

["Chen, Jing D" <jing.d.chen@intel.com>]

Hi, Bruce,

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, June 17, 2016 6:19 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast
> traffic
> 
> On Mon, Jun 06, 2016 at 05:00:47PM +0800, Wang Xiao W wrote:
> > When app tries promisc/allmulti setting, fm10k will check if a valid
> > glort is acquired, if not then exit without doing anything. It's a
> > long journey for VF to acquire glort info from VF to PF mailbox, PF to switch
> mailbox.
> > It could be a long interval that's out of DPDK's control. Thus, app
> > may
> 
> I think the use of "thus" here is wrong, as I suspect that the failure is not due
> to the "long interval that's out of DPDK's control", but instead due to not
> having a valid glort.

The logic in VF is glort ID is invalid at beginning. When VF port is enabled by
sending mailbox to PF, PF will send a message back to VF without carrying valid
info. Then, VF will fake a glort ID. 
In this case, it's useless to do sanity check of VALID glort ID.  Besides that, VF didn't
use glort ID to do functional call at all.
	
> 
> > fail on promisc/allmulti setting in VF. In fact, we don't need a valid
> > glort value in VF, so this patch just skips the glort check for VF.
> >
> > Fixes: df02ba864695 ("fm10k: support promiscuous mode")
> >
> > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> 
> I rework this commit message for you on apply. Please check the updated
> version when done.
> 
> /Bruce