From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6FD439ABC for ; Sun, 19 Jun 2016 15:47:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 19 Jun 2016 06:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,493,1459839600"; d="scan'208";a="1001007034" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 19 Jun 2016 06:47:41 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 19 Jun 2016 06:47:39 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 19 Jun 2016 06:47:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Sun, 19 Jun 2016 21:47:36 +0800 From: "Chen, Jing D" To: "Richardson, Bruce" , "Wang, Xiao W" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic Thread-Index: AQHRv9H6sS6bOVWbPkqiIvXh2ZDVfZ/s/XQAgAPh5oA= Date: Sun, 19 Jun 2016 13:47:36 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D044CEB6F@shsmsx102.ccr.corp.intel.com> References: <1465203647-18717-1-git-send-email-xiao.w.wang@intel.com> <20160617101833.GB14948@bricha3-MOBL3> In-Reply-To: <20160617101833.GB14948@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTE1OGEzYzgtMWZkNC00NmI4LTk5NTktOWQxZTY5NmUyYzhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRsaWxJYnhBanF5UnVHRFJaNVpobGFsajAzaUdTUnVSMHhWXC91WXlRdElvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 13:47:41 -0000 Hi, Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, June 17, 2016 6:19 PM > To: Wang, Xiao W > Cc: Chen, Jing D ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast > traffic >=20 > On Mon, Jun 06, 2016 at 05:00:47PM +0800, Wang Xiao W wrote: > > When app tries promisc/allmulti setting, fm10k will check if a valid > > glort is acquired, if not then exit without doing anything. It's a > > long journey for VF to acquire glort info from VF to PF mailbox, PF to = switch > mailbox. > > It could be a long interval that's out of DPDK's control. Thus, app > > may >=20 > I think the use of "thus" here is wrong, as I suspect that the failure is= not due > to the "long interval that's out of DPDK's control", but instead due to n= ot > having a valid glort. The logic in VF is glort ID is invalid at beginning. When VF port is enable= d by sending mailbox to PF, PF will send a message back to VF without carrying v= alid info. Then, VF will fake a glort ID.=20 In this case, it's useless to do sanity check of VALID glort ID. Besides t= hat, VF didn't use glort ID to do functional call at all. =09 >=20 > > fail on promisc/allmulti setting in VF. In fact, we don't need a valid > > glort value in VF, so this patch just skips the glort check for VF. > > > > Fixes: df02ba864695 ("fm10k: support promiscuous mode") > > > > Signed-off-by: Wang Xiao W >=20 > I rework this commit message for you on apply. Please check the updated > version when done. >=20 > /Bruce