From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1E3594B79 for ; Fri, 22 Jul 2016 11:05:39 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 22 Jul 2016 02:05:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,404,1464678000"; d="scan'208";a="1011825441" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 22 Jul 2016 02:05:39 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 22 Jul 2016 02:05:39 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 22 Jul 2016 02:05:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.181]) with mapi id 14.03.0248.002; Fri, 22 Jul 2016 17:05:37 +0800 From: "Chen, Jing D" To: Thomas Monjalon CC: "dev@dpdk.org" , "Wang, Xiao W" , "Lin, Xueqin" Thread-Topic: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config Thread-Index: AQHR4ylUxz43l/qlu0q4Sqo5t+jhr6Aikg7g//+H/oCAAX2iAIAAhkkg//97uACAAI8TgA== Date: Fri, 22 Jul 2016 09:05:37 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D044DF6E5@shsmsx102.ccr.corp.intel.com> References: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com> <91849256.XuHjXYpFvk@xps13> <4341B239C0EFF9468EE453F9E9F4604D044DF694@shsmsx102.ccr.corp.intel.com> <2478490.ThySIcn2fe@xps13> In-Reply-To: <2478490.ThySIcn2fe@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 09:05:40 -0000 Hi, Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, July 22, 2016 4:29 PM > To: Chen, Jing D > Cc: dev@dpdk.org; Wang, Xiao W ; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config >=20 > 2016-07-22 08:23, Chen, Jing D: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-07-21 09:35, Wang, Xiao W: > > > > From: Chen, Jing D > > > > > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > > > > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > > > > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev > *dev, > > > > > > > > > > > > PMD_INIT_FUNC_TRACE(); > > > > > > > > > > > > - if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > > > > > - FM10K_RSSRK_ENTRIES_PER_REG) > > > > > > + if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > > > > > + FM10K_RSSRK_ENTRIES_PER_REG)) > > > > > > return -EINVAL; > > > > > > > > > > > > if (hf =3D=3D 0) > > > > > > > > > > It's also possible that app wants to update rss key and not expec= t to update > hash > > > > > function. > > > > > Is that indicate we shouldn't return error in case hf =3D=3D 0? > > > > > > > > > > > > > If the app just wants to update RSS key, it needs to read out the R= SS config first, > > > then > > > > change only the key field. This is what testpmd does for this opera= tion. > > > > > > > > hf =3D=3D 0 will disable RSS feature, I think we should return erro= r to protect > multi- > > > queue. > > > > > > Jing, do you confirm we can apply this patch, please? > > I think we need some rework or more explanations here. >=20 > It is not reasonnable to wait RC5 for such a fix. > Either it is not important and postponed to 16.11 or you submit > a v2 very shortly for 16.07. > Please advise Please kindly merge.