From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 08BE22B88 for ; Mon, 29 Aug 2016 11:32:38 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 29 Aug 2016 02:32:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,596,1464678000"; d="scan'208";a="161987828" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 29 Aug 2016 02:32:37 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Aug 2016 02:32:37 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Aug 2016 02:32:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0301.000; Mon, 29 Aug 2016 17:32:35 +0800 From: "Chen, Jing D" To: "Wang, Xiao W" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/5] net/fm10k: implement new Rx checksum flag Thread-Index: AQHR/vjoRCMAS67qQUSL0WyP4MmSLKBfsaRA Date: Mon, 29 Aug 2016 09:32:34 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3A2D5F05@SHSMSX104.ccr.corp.intel.com> References: <1472147299-2376-1-git-send-email-xiao.w.wang@intel.com> <1472147299-2376-3-git-send-email-xiao.w.wang@intel.com> In-Reply-To: <1472147299-2376-3-git-send-email-xiao.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] net/fm10k: implement new Rx checksum flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 09:32:39 -0000 Hi, > uint16_t > diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c > b/drivers/net/fm10k/fm10k_rxtx_vec.c > index 9ea747e..8c08b44 100644 > --- a/drivers/net/fm10k/fm10k_rxtx_vec.c > +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c > @@ -95,8 +95,10 @@ fm10k_desc_to_olflags_v(__m128i descs[4], struct rte_m= buf > **rx_pkts) > const __m128i l3l4cksum_flag =3D _mm_set_epi8(0, 0, 0, 0, > 0, 0, 0, 0, > 0, 0, 0, 0, > - PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD, > - PKT_RX_IP_CKSUM_BAD, PKT_RX_L4_CKSUM_BAD, 0); > + (PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD) >> 1, > + (PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD) >> > 1, > + (PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD) >> > 1, > + (PKT_RX_IP_CKSUM_GOOD | > PKT_RX_L4_CKSUM_GOOD) >> 1); Can we define a macro, like "#define RTE_CKSUM_SHIFT 1" to avoid numeric? >=20 > const __m128i rxe_flag =3D _mm_set_epi8(0, 0, 0, 0, > 0, 0, 0, 0, > @@ -139,6 +141,7 @@ fm10k_desc_to_olflags_v(__m128i descs[4], struct > rte_mbuf **rx_pkts) > /* Process L4/L3 checksum error flags */ > cksumflag =3D _mm_srli_epi16(cksumflag, L3L4EFLAG_SHIFT); > cksumflag =3D _mm_shuffle_epi8(l3l4cksum_flag, cksumflag); > + cksumflag =3D _mm_slli_epi16(cksumflag, 1); > vtag1 =3D _mm_or_si128(cksumflag, vtag1); >=20 > vol.dword =3D _mm_cvtsi128_si64(vtag1); > -- > 1.9.3 Besides that, just realize we should remove "hw_ip_checksum" check in func fm10k_rx_vec_condition_check() since we already support it. Can you help to make the change?