From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 883B29E3; Wed, 21 Jun 2017 04:35:41 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2017 19:35:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,367,1493708400"; d="scan'208";a="1162846840" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 20 Jun 2017 19:35:40 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Jun 2017 19:35:40 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Jun 2017 19:35:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Wed, 21 Jun 2017 10:35:36 +0800 From: "Chen, Jing D" To: "Wang, Xiao W" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/fm10k: initialize link status in device start Thread-Index: AQHS2bSkmetPUOH68kqpuHF36voznKIuuQfg Date: Wed, 21 Jun 2017 02:35:36 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3C66E99C@shsmsx102.ccr.corp.intel.com> References: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> In-Reply-To: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: initialize link status in device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 02:35:42 -0000 Hi, > -----Original Message----- > From: Wang, Xiao W > Sent: Wednesday, May 31, 2017 7:07 PM > To: Chen, Jing D > Cc: dev@dpdk.org; Wang, Xiao W ; > stable@dpdk.org > Subject: [PATCH] net/fm10k: initialize link status in device start >=20 > If port LSC interrupt is configured, application will read link status di= rectly, so > driver need to prepare that value in advance. Fm10k host driver can't manage PHY directly and provide a fake link status,= =20 so it always provide a constant value, whatever lsc is set or not. I think you need to reorganize the message. :) >=20 > Fixes: 9ae6068c86da ("fm10k: add dev start/stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Wang > --- > drivers/net/fm10k/fm10k_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index a742eec..54bf10c 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -84,6 +84,8 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev > *dev, static void fm10k_set_rx_function(struct rte_eth_dev *dev); stati= c > void fm10k_set_tx_function(struct rte_eth_dev *dev); static int > fm10k_check_ftag(struct rte_devargs *devargs); > +static int fm10k_link_update(struct rte_eth_dev *dev, > + __rte_unused int wait_to_complete); >=20 > struct fm10k_xstats_name_off { > char name[RTE_ETH_XSTATS_NAME_SIZE]; > @@ -1166,6 +1168,9 @@ static inline int fm10k_glort_valid(struct fm10k_hw > *hw) > if (!(dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_VMDQ_FLAG)) > fm10k_vlan_filter_set(dev, hw->mac.default_vid, true); >=20 > + if (dev->data->dev_conf.intr_conf.lsc !=3D 0) > + fm10k_link_update(dev, 0); > + I'll recommend updating link status anyway when port starts, not considerin= g lsc set status. > return 0; > } >=20 > -- > 1.8.3.1