From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11F2842643; Tue, 26 Sep 2023 15:14:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01CE340A87; Tue, 26 Sep 2023 15:14:05 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2046.outbound.protection.outlook.com [40.107.93.46]) by mails.dpdk.org (Postfix) with ESMTP id 4B07E40A81 for ; Tue, 26 Sep 2023 15:14:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdGorVA7GnCMuUK4GBu5RgiywBLLuUNugwrlnKMFleTp2zeGpbq+rnBrNylTRHuBOkGwY7+Aj+ZaVYQguGM6PtGgkQc7sB7XTGf/xHt7hRUimkO309K/nZX2saTYhMsqi6WF62hrMm9Hq+a17kXw12j5tjh9GWJyzrrzTSzAJw5AzsXAfwEUiCw6h7BBeJ7XUkAXOaOd5Qef34+BI3m/Zr3GdYH5AoNvHjLt3G3B43A/Esu/2bQpkO1hHFbhVKR/krZN03GX8YeAYlBK72RHxcM8gLuabZW+CTWO42x7XluaKNlrPKrqRKXVeS2NYaP6eIQ0YG0DaZLDitnPdhdwFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JQl14dIYGZXJQpkFMLC+n9yCFOBlnUTW0sMz5y7Fuws=; b=aYdevS7AAA3erk56UMyREtjqR2UvYaxbu1b/lAFa0X+8AtLX6oTEijbnf3t4WSZgDvBUR3GuZhp/q68kf4nq7yN7x+loATrKMB6W46xj5PG7mhLZHjonY58Yv0jETZ5Bn8U2Io4ytT6Wfyugsu/X+N6a6l5B9dqvZCJIMjKV7/0JKn82YaRGFvSDiwCcIhtRCxm64rREpF38OY8DCO0Ck7eTjJRhnmhkjyd5snLViniok9HlvlPYO6LKzaJiWNYxktLf4z8t/QggRfSuP4bbcryqBC/h2I+28z5foi2W1/M9IlWA2OaxDvXIocH11w7SFtgUFTqskGKJkSOcbWpq5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQl14dIYGZXJQpkFMLC+n9yCFOBlnUTW0sMz5y7Fuws=; b=f2RVKwAgK8RIfe8vpSjnojmrAvym4DZGUm2Nj2OgvdF6MIJxdDlDzj9pdiU6RqcfhNej6EtSSQPtN/0T0BgQH+NVuRLOpZNk/vybIrzwGIXagPyOqgZbqGvApMknbZfu6o+gskO3qCbnZ6viz32OEN7MR2awf2l+pib7VyhTyhg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB8291.namprd12.prod.outlook.com (2603:10b6:8:e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 13:14:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 13:14:01 +0000 Message-ID: <434540b7-0b12-4cc9-9406-f7a51f1ac12f@amd.com> Date: Tue, 26 Sep 2023 14:13:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters Content-Language: en-US To: wanry@3snic.com, dev@dpdk.org References: <20230904045658.238185-1-wanry@3snic.com> Cc: Stephen Hemminger From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230904045658.238185-1-wanry@3snic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB8291:EE_ X-MS-Office365-Filtering-Correlation-Id: 15c34da2-be07-4c5a-e4ee-08dbbe92732b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sUj60JVScJx8r8fIkYsBWa5cEn08NpIz6j5Wnzg8zsm2Trxn6TM3PlFDG4enVuQHt2I0uaNuSU900ml98kEKMWQexz9H2BoKKABJ6rXAB5F0GvC8kk2b0ktcv5NPBCrgaCRYpSf1j7zEnp++IxYAXFfYUoZbSwmXvXpZxfqWBDe+cHwyE6A3GFtCqGLLIxgABtNh2zQ/Glm0BJPL7sMDYImxL7ZBI+2fj2udDTiH9bQHigP2J/Wsc+Cty1Hto+gtFyXSzKtisRs9BvuO31x/SOWNGNDy9QmpmCQfZ8mctc0ZZ9yqN9QBuMSD+qJsf3ySX3N0a2JZMUfYMegfacvf89FZv001Z8wYjqjkk/IXyPpPmKicoFA2FiZQd+Wk/28MQPwM6s2HubEsPsm50s0FVelkQTFuZiXFFNAg7HVmKxYmIajgpaDMYhPt6XQowp436ZjIGozRGKWBz6Nk/Kd08SulEpvhIl4GUFeZr7AviVhNgEdZdIuK+SwDxvTSXp/nU+HhvKOEWcbW4VM1KIXBmaAIBwNFDqz1xkBBflQ3koiEmCMFMRFU6R6KsC6Wp0Gk7K4Ex2Z8LK/B4tPNQQVy1HVld8G588C0TVg5bmVlaVd19H4jZrP9o5iOj+ltwjP/W4T+TlOpgLBmKwUTs3DIcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(366004)(376002)(396003)(136003)(230922051799003)(1800799009)(186009)(451199024)(6512007)(6486002)(53546011)(6506007)(83380400001)(86362001)(31696002)(38100700002)(36756003)(2616005)(44832011)(2906002)(26005)(31686004)(8936002)(8676002)(4326008)(316002)(66556008)(41300700001)(66946007)(66476007)(5660300002)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SENpSnNnbkRTdEhac21abGdXaURiZytRQXM5ckRrenkrUWVjcmRPQkVKbzNY?= =?utf-8?B?UUg1bTV4SmZZOWNmL280ZGJ3SnZDV08ydU9WWGxkTWFNZzdjRjdCRWhNL0cv?= =?utf-8?B?ekU5Vjcyc1FkOWNLK2dTRkwxRmIvRkJDaW43Sysrd0QrNkJ5U1dpaFBONjI3?= =?utf-8?B?QThyYXBJZlVUYlo4aWgxRTFRQU5ST2hma1d2OTl3cHdvZnhEWE0wMHNkUkRE?= =?utf-8?B?SnkwS2E0a2lzdlEvQTBoMEVLNGV5NG9tNzJqamRydlpXUXREVlVETmo5N2hv?= =?utf-8?B?dXlmcmlLOXlMbVVKRDMwS3lkUEgwNG0rd21vTEpmb24vd3U3VnYzaGRqZ2dE?= =?utf-8?B?WEZBSVhBemxNWkVRaElNRit0SHNhTjBsZXZEc3o2Y2V2OEhhQlpwYkxpUEJj?= =?utf-8?B?YitaQjFxb2UrdVh0SzAzOG5Vb1NMKzlYSjdBbTBXdlRVOTEyOTBtK01wOHQ2?= =?utf-8?B?ei8wMm1CL0ozZmdONFRXRkhuYU1hQnR5Vjk2K0M3M3hwV2xjSEx0ZmZuaWs1?= =?utf-8?B?R1UxaGNlRC9WMGRRMjVsN2xUeHFwWjRXZEFGRjEza3M2TVZjT1ptamxvS0ti?= =?utf-8?B?UzUxWjhLZWRlcFBlMFZFZ0VWUjZtOGtFcXB2YXNlT0NMZDhua3JINzBoQVZ0?= =?utf-8?B?QXpBRUNnSFlURzNPdjlQdkRYYXlnQW1GcUUrRkdPM2FUT3E3cngrRk5NUytv?= =?utf-8?B?emNxclVpUlZxTm91TkZKcTh2dDZqcEg3ZTBCYzFvSFZVS1J6MDQxMWQ5Y0ZX?= =?utf-8?B?UC9VZFpjZ0h3MVZJeGhCd0Rpc3NGN0tmSFBNTldQajE3cG8reUZkSjNLSDBh?= =?utf-8?B?REdweDMySzFCOXNkUGNHL3VFYXIyeHNUR2wzK0ZQekZRMXMzRkZzS09CSitx?= =?utf-8?B?MjdzZnlrMHljMU90djlvZk5Rb05WYkswWmswcU5PTlh6THdhei9kWVdKanpJ?= =?utf-8?B?dHVMcXpEVTRlTGRjVXgzcHVycTM4amQzcS9uMXBwVFZ4Qit2N2VjYUdUbkR5?= =?utf-8?B?aWdmbGJtcHUyajdKV1pLWUhIc0ZXSHF6SjlwNWdHQzlCMldUQkxvN3gxbmkr?= =?utf-8?B?L0FHM3JFK1ZVMjdTZnZzejNFeG9CZ042RW40SG1GM2pjbzA1MXc0ellLbXNz?= =?utf-8?B?WTRhZ29lWmRwcEZYOUJmQnRwSXo4RXRUYmhwZ0tldm5ZbHBMN1N0clJNeXhC?= =?utf-8?B?S1Y1Znc0V0I0ODdNMm5rUXRSNWNkK3FqVWltRFdXTHBwUlpuZXNONUxFSE5L?= =?utf-8?B?dUFUQ0N6eHB0MmlzN2JGM2Z5blZuK3Z6QmN2SmswQ3EvazlUbTlhQmdTNS9s?= =?utf-8?B?SDRuN2NjWmJINWtNMG9HYkdBVkk1ZGt4eXppaUVsSGphT0VPc0NMOU4zVWF3?= =?utf-8?B?ODFqMk95UGpiWnFsUmFIY3lMNm9yTkJISzk2RG9uZGNCUVUybDJqM1BqTlBZ?= =?utf-8?B?UWJvN3plUlpZV3N2UEwyYkt3elZ5S3BBc0pVNjBDVE1sUnBsaXRQdzdzQ3lh?= =?utf-8?B?am0wbmUwZ3ZxK0lXVmtvUExrYlFDSkowWlh3cjFxNXlIRG45enVmcDZaOVNj?= =?utf-8?B?NWhsTjF0SzEwSnBHb0haQy9EUU1ybENUYjl0UDRCZTJZN2hYY0c3bVQzR0JV?= =?utf-8?B?OFdSWHVzWjcwdzEva2hUaXdDeFA4dVJUckJuQ3NRdFBEbnVnZ2VMODVuL0w3?= =?utf-8?B?TVo0dlZQekE1Z2lEY3dzbStMcnJUTEpqTjh6c3JlN0dKaW91RllIbUFKL2FR?= =?utf-8?B?cXdicm0zNzVDbkgzM2dEMTEySDI0TzRWTHk0UDlnTncvRHpnaVFqSG5PKzEv?= =?utf-8?B?UStKUnBPemI4UVFwd0ZkQnNsTU43dGdBdlJtbFk0d2ljVmdlbzJ2ZFkzWVFi?= =?utf-8?B?eGFZM1JoUUIrd0lDSmxOZXprS3VPN0FqU1k5Wlg1aGJsOWI0bDROQnBBZElT?= =?utf-8?B?bExySjBRWlpFd2ZRR1V0VUx0WmZKU3hkcm1iS2VpRkRmalc1aS8ycE5YZ3Nx?= =?utf-8?B?WGRYdTFiWGR5TjdycnFtWTd5VzJKWFkxV1VQR1hUL28za2o4SGZTeXQ2S2o4?= =?utf-8?B?bWVXMkNUVzNkaGxEU1Z3OTNiQUZBYUV0em9HZmFVdzRMdUV2YnRUZ1BFR3Mw?= =?utf-8?Q?RYjZ/ZPTmHPwylXN1h/zrenms?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15c34da2-be07-4c5a-e4ee-08dbbe92732b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 13:14:01.6896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cu+f+oA01MbgGe1NyufsgsbF7VhiWFx+8IRIT38E49+ENt93IQw3whyjMR/SeWsI X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8291 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/4/2023 5:56 AM, wanry@3snic.com wrote: > From: Renyong Wan > > The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support > for 3SNIC 9x0 serials family of Ethernet adapters. > > Supported NICs are: > > - 3S910 Dual Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port QSFP28 100GbE Ethernet adapter > > Features of sssnic PMD are: > > - Link status > - Link status event > - Queue start/stop > - Rx interrupt > - Scattered Rx > - TSO > - LRO > - Promiscuous mode > - Allmulticast mode > - Unicast MAC filter > - Multicast MAC filte > - RSS hash > - RSS key update > - RSS reta update > - Inner RSS > - VLAN filter > - VLAN offload > - L3 checksum offload > - L4 checksum offload > - Inner L3 checksum > - Inner L4 checksum > - Basic stats > - Extended stats > - Stats per queue > - Flow control > - FW version > - Generic flow API > > --- > v2: > * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst. > * Removed error.h from including files. > * Fixed variable 'cmd_len' is uninitialized when used. > * Fixed 'EINVAL' undeclared. > * Fixed wrong format of printing uint64_t. > * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'. > > v3: > * Fixed dereferencing type-punned pointer in base/sssnic_mbox.c. > > v4: > * Fixed dereferencing type-punned pointer in base/sssnic_eventq.c. > * Fixed coding style issue of COMPLEX_MACRO. > * Fixed coding style issue of REPEATED_WORD. > > v5: > * Fixed rebase mistake. > * Fixed incorrect path in MAINTAINERS file. > --- > > Renyong Wan (32): > net/sssnic: add build and doc infrastructure > net/sssnic: add log type and log macros > net/sssnic: support probe and remove > net/sssnic: initialize hardware base > net/sssnic: add event queue > net/sssnic/base: add message definition and utility > net/sssnic/base: add mailbox support > net/sssnic/base: add work queue > net/sssnic/base: add control queue > net/sssnic: add dev configure and infos get > net/sssnic: add dev MAC ops > net/sssnic: support dev link status > net/sssnic: support link status event > net/sssnic: support Rx queue setup and release > net/sssnic: support Tx queue setup and release > net/sssnic: support Rx queue start and stop > net/sssnic: support Tx queue start and stop > net/sssnic: add Rx interrupt support > net/sssnic: support dev start and stop > net/sssnic: support dev close and reset > net/sssnic: add allmulticast and promiscuous ops > net/sssnic: add basic and extended stats ops > net/sssnic: support Rx packet burst > net/sssnic: support Tx packet burst > net/sssnic: add RSS support > net/sssnic: support dev MTU set > net/sssnic: support dev queue info get > net/sssnic: support dev firmware version get > net/sssnic: add dev flow control ops > net/sssnic: support VLAN offload and filter > net/sssnic: add generic flow ops > net/sssnic: add VF dev support > Hi Renyong, Driver mostly looks good, I did put some minor comments, I guess driver can be merged soon with those issues addressed. Also agree on Stephen's comments, if you apply them in next version, please feel free to keep Stephen's ack in next version. Thanks, ferruh