From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id A88419398 for ; Wed, 21 Oct 2015 11:25:17 +0200 (CEST) Received: by wicfv8 with SMTP id fv8so65592585wic.0 for ; Wed, 21 Oct 2015 02:25:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zeTCVdkwixLHyAIEnK86ZSzyFTFYzMs+/FU4on/kP7U=; b=PYUHpN64Zyw4UPXKxq3kuJHLtCh6qhNw7zkKIct4kzB5sHaAQWoZNNjhEZwKRmDnOZ 7lPGardxSeYArtup5/1q2znKQPgupB7byyoEiJC3u+rwtgGG3x/hb4yLkSMMJ7hu1MLY /q6nKA+iXpUn7kz0sZO9VTIWcewquSxxSkPncnny9D5FtVTsuw+e3qMq8gmC/LG7rV5p Na6/KSGYOD7Hc1dQW/o+F69T+Ea0b4wgw/TDaRsSGGT6wVBHHRcNHITWeLiYH1P2WjrS xMjGOamwohnSPmPmMKFLHxCJNu5jGLcbXCPnY53IKTel9zW1vFftD6WjCTWWJkVGYxnZ xBHw== X-Gm-Message-State: ALoCoQnhuCBmQEP3zgJLMxJuVgtNrnNPftM8I/JtBd2dWgZIOy2y0PAJKzwIHzsI9mnUGF1OksSk X-Received: by 10.180.210.210 with SMTP id mw18mr31257197wic.18.1445419517504; Wed, 21 Oct 2015 02:25:17 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id cv1sm22914964wib.18.2015.10.21.02.25.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 02:25:16 -0700 (PDT) From: Thomas Monjalon To: Declan Doherty Date: Wed, 21 Oct 2015 11:24:12 +0200 Message-ID: <4348530.B8pRXVWZvF@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1443826867-21004-2-git-send-email-declan.doherty@intel.com> References: <1443826867-21004-1-git-send-email-declan.doherty@intel.com> <1443826867-21004-2-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/6] cryptodev: Initial DPDK Crypto APIs and device framework release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 09:25:17 -0000 Hi Declan, 2015-10-03 00:01, Declan Doherty: > Co-authored-by: Des O Dea > Co-authored-by: John Griffin > Co-authored-by: Fiona Trahe Common practice is to use Signed-off-by below for co-authors. > This patch contains the initial proposed APIs and device framework for > integrating crypto packet processing into DPDK. > > features include: > - Crypto device configuration / management APIs > - Definitions of supported cipher algorithms and operations. > - Definitions of supported hash/authentication algorithms and > operations. > - Crypto session management APIs > - Crypto operation data structures and APIs allocation of crypto > operation structure used to specify the crypto operations to > be performed on a particular mbuf. > - Extension of mbuf to contain crypto operation data pointer and > extra flags. > - Burst enqueue / dequeue APIs for processing of crypto operations. It would be easier to review if features were split in separate patches. You don't need to have a fine grain but maybe 1 patch for basic management then 1 for the session management, 1 for the algos and another 1 for the stats. Other comment: you've added some API which are not implemented (hotplug, restore). Why not declare them later when they will be implemented? The QuickAssist doc is not needed if the code is not submitted. Volunteer for a sub-tree? Thanks.