From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens
Date: Fri, 02 Nov 2018 10:39:24 +0100 [thread overview]
Message-ID: <4348558.Aku75RrXBD@xps> (raw)
In-Reply-To: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
02/11/2018 07:00, Arnon Warshavsky:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -49,13 +49,16 @@ check_forbidden_additions() { # <patch>
> awk -v FOLDERS="lib drivers" \
> -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
> -v RET_ON_FAIL=1 \
> + -v MESSAGE='Using rte_panic/rte_exit' \
> -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
> "$1"
> # svg figures must be included with wildcard extension
> # because of png conversion for pdf docs
> + message="Using explicit .svg extension in figures instead of .*"
> awk -v FOLDERS='doc' \
> -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
> -v RET_ON_FAIL=1 \
> + -v MESSAGE="$message" \
> -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
> "$1"
> }
Why using a variable for message in the second check?
next prev parent reply other threads:[~2018-11-02 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 6:00 Arnon Warshavsky
2018-11-02 9:39 ` Thomas Monjalon [this message]
2018-11-02 10:37 ` Arnon Warshavsky
2018-11-02 10:43 ` Thomas Monjalon
2018-11-02 10:47 ` Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4348558.Aku75RrXBD@xps \
--to=thomas@monjalon.net \
--cc=arnon@qwilt.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).