[dpdk-dev] Removal of IP version from packet offload feature flags

[dpdk-dev] Removal of IP version from packet offload feature flags

[Martin Drašar]

Hi,

I just tried to upgrade to 2.1.0 and suddenly my code stopped compiling,
because of using PKT_RX_IPV4_HDR feature flag and the like. In the
rte_mbuf.h there is this code:

> #ifndef RTE_NEXT_ABI
> #define PKT_RX_IPV4_HDR      (1ULL << 5)  /**< RX packet with IPv4 header. */
> #define PKT_RX_IPV4_HDR_EXT  (1ULL << 6)  /**< RX packet with extended IPv4 header. */
> #define PKT_RX_IPV6_HDR      (1ULL << 7)  /**< RX packet with IPv6 header. */
> #define PKT_RX_IPV6_HDR_EXT  (1ULL << 8)  /**< RX packet with extended IPv6 header. */
> #endif /* RTE_NEXT_ABI */

So I guess that means the code got deprecated between 2.0.0 and 2.1.0,
although I did not find relevant comment in the changelog. My question
is, what should I use instead and even better - why was this change made?

Thank you,
Martin

Re: [dpdk-dev] Removal of IP version from packet offload feature flags

[Thomas Monjalon]

2015-08-31 10:03, Martin Drašar:
> I just tried to upgrade to 2.1.0 and suddenly my code stopped compiling,
> because of using PKT_RX_IPV4_HDR feature flag and the like. In the
> rte_mbuf.h there is this code:
> 
> > #ifndef RTE_NEXT_ABI
> > #define PKT_RX_IPV4_HDR      (1ULL << 5)  /**< RX packet with IPv4 header. */
> > #define PKT_RX_IPV4_HDR_EXT  (1ULL << 6)  /**< RX packet with extended IPv4 header. */
> > #define PKT_RX_IPV6_HDR      (1ULL << 7)  /**< RX packet with IPv6 header. */
> > #define PKT_RX_IPV6_HDR_EXT  (1ULL << 8)  /**< RX packet with extended IPv6 header. */
> > #endif /* RTE_NEXT_ABI */

In order to keep compatibility with your old code, you have to disable
RTE_NEXT_ABI in your configuration file (.config).

> So I guess that means the code got deprecated between 2.0.0 and 2.1.0,
> although I did not find relevant comment in the changelog. My question
> is, what should I use instead and even better - why was this change made?

See "Extended packet type support" in
	http://dpdk.org/doc/guides/rel_notes/release_2_1.html
and
	http://dpdk.org/doc/guides/rel_notes/deprecation.html

Re: [dpdk-dev] Removal of IP version from packet offload feature flags

[Thomas Monjalon]

2015-08-31 12:40, Martin Drašar:
> Dne 31.8.2015 v 10:56 Thomas Monjalon napsal(a):
> > In order to keep compatibility with your old code, you have to disable
> > RTE_NEXT_ABI in your configuration file (.config).
> 
> I have done this and the code works, but because the project is in
> prototype stage, I would like to keep it working with the newest version.
> 
> > See "Extended packet type support" in
> > 	http://dpdk.org/doc/guides/rel_notes/release_2_1.html
> > and
> > 	http://dpdk.org/doc/guides/rel_notes/deprecation.html
> >
> 
> Now I remember that I read this. However, nowhere I see possible values
> for the packet_type. Is it documented somewhere, or will this be
> documented in upcoming release?

It does not appear in doxygen (patch welcome) but it is documented.
Check RTE_PTYPE_* in lib/librte_mbuf/rte_mbuf.h

Re: [dpdk-dev] Removal of IP version from packet offload feature flags

[Martin Drašar]

Dne 31.8.2015 v 14:22 Thomas Monjalon napsal(a):
> It does not appear in doxygen (patch welcome) but it is documented.
> Check RTE_PTYPE_* in lib/librte_mbuf/rte_mbuf.h

Thanks! I was looking, but not good enough.
Indeed the defines are there and everything is working again :-)

However, I have no idea why the documentation does not show up in html,
when it is in the code...

Martin