From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E00F61B0F9; Tue, 15 Jan 2019 02:53:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5AFE42906C; Mon, 14 Jan 2019 20:53:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 20:53:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Tfy+fzfMvhEBKo5vqBOQuOynOhJTjVa/h0UxhfafYbA=; b=jBhInEbJDSGn TZ7FDpDxp4YU+Egx1B1smLYr2hLiX09a0SzTsY4lkalH/nXipBXdFAktFA9auw4J 1G9SW89ncw8yRpq2rUPAPRUed1e25miiDLM2+dQBm6341ke5Zqk2fHNBGubbVHap YiioDft4ljEoZW4HRcM+kOHumW6RJfA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Tfy+fzfMvhEBKo5vqBOQuOynOhJTjVa/h0UxhfafY bA=; b=LXYA+N5j968k5Cpr3ptS5hPbpOeMNuIsvX6AEq/mfDmoyvg2mo/ibikdT EA25/2DefTkn3JeC+cOJs8l1GirEbmSXuvdETus2kHpwH/OFeH+c88yI2hOgpUlZ GuAC3SiGlqDtUwQJFQSCeozPqQvYE/8gdMKZZMo/L6efSWI+p3pt92zpe2lAO6AD I2CLDukfJYTpfbgu9pQg07V/FYJqzLIfApO7ARvA2xeZl8rtZV/Z5v59+WxVcwaR qK0c9dugW4jy4UG4bXKH8fTAFwC3N0jfJnon7pnenarYJkWuD9IcbcHk8kwHV/bH egNM4P6704lCS3jkqX/0NbBU7pGyg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 127DDE465D; Mon, 14 Jan 2019 20:53:28 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Chaitanya Babu Talluri , reshma.pattan@intel.com, rmody@marvell.com, shshaikh@marvell.com, beilei.xing@intel.com, qi.z.zhang@intel.com, alejandro.lucero@netronome.com, pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, stable@dpdk.org Date: Tue, 15 Jan 2019 02:53:28 +0100 Message-ID: <4355742.ZHn0J28zhk@xps> In-Reply-To: <20190114142133.GA16996@bricha3-MOBL.ger.corp.intel.com> References: <1547445875-24601-1-git-send-email-tallurix.chaitanya.babu@intel.com> <20190114142133.GA16996@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 01:53:32 -0000 14/01/2019 15:21, Bruce Richardson: > On Mon, Jan 14, 2019 at 06:04:35AM +0000, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. [...] > > While I believe this is correct, this (and the changes below) would be a > lot neater using strlcat function. We should perhaps look to add strlcat > alongside strlcpy for DPDK use. Yes it looks reasonnable.