From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id F0EB0A0C43;
Wed, 20 Oct 2021 21:14:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B8C0C40150;
Wed, 20 Oct 2021 21:14:09 +0200 (CEST)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
[66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 4F9A540142
for <dev@dpdk.org>; Wed, 20 Oct 2021 21:14:08 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
by mailnew.nyi.internal (Postfix) with ESMTP id 90230580FE1;
Wed, 20 Oct 2021 15:14:07 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute3.internal (MEProxy); Wed, 20 Oct 2021 15:14:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
HXv+QOuFzdGp/jeijl8nUtKklThi8MawDwWtsk/I1p8=; b=nJdT5oLTI90jGAy0
ZZh7PxZvqpF+bGK/Nw1K6K9AZB5iLR9MSFGIeelaFYaIdZvEIZ4ASI3jedvivSAR
Gj0iw4+aIKtmyyZ9p6fkXlkFEJY3zt5eQxUlJnNUG6EQ7AJsk6LHFhcQt+L56s25
15ar4vdp5WHMq3EDCTJ+W8ir4XSplMjLt9K+K/c1A586+HS2SUn4hNlXFzQhO9b8
GnRsTflKaICuCzWeU6Emv4oBqBMhUig8z2aHMe9X8N11uk7re//OQi+KfzTVlXpF
nFjsj0ZrRIJW/rV9447UM1tlyH74vkarSI+dQ+qKLi/p4NAdxibNG5FjFa1IYm+j
xxUn8Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=HXv+QOuFzdGp/jeijl8nUtKklThi8MawDwWtsk/I1
p8=; b=Im9rsi0RoB340+c+dsP30e10P1JjKYkFnOOPQYbLKlI3zk8Tg3H9EB2C4
/LBx0Du9oS5eQE9M8j7t1D66wtGny6KBPjGNiK4pQ+Ta2QDz6B5/gHhX1OVGg76I
ZZqbL2cHaGiJqgak2HH5U0Q6fBrDeJThVGBdxR1nZOB1kgpcsMbtqyVtUOoKHS/g
V+UHtz+2Q733nfKZuKm76fM6qZil+UnAaejNxNS5mVZdwXOm5bdZCXmLP94H5TBD
upziUUyZiF8PrPN8uI5mg5XtmIaVUnH1WfK3R3pqW/SHr3sykdy2Zy7POboT/f3M
vX00XyB80nkgbsaMeR9zmUNfPPBXg==
X-ME-Sender: <xms:f2pwYTixb4vzCnpXQ2dGmFsfmAHIgd2aIJtpLQ73KubAReFEeAI9Ag>
<xme:f2pwYQDhXO_Q_Svsx8ljo-JrkaPVRJlicfuVI0dFu1ujBxvvR_bFced7YeiVItaYl
GiXQxwrxrXhIGER8w>
X-ME-Received: <xmr:f2pwYTElEsA_8Sc7YOgnHmuGmB1m5qjVPdy8qs_yy-VDV2uNJOQQhvkBfrljTTWpbhD6NiA8RfqOjR7w_PBSuZ4dnQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvgedgudeftdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:f2pwYQRIMyFFymkdaeQJ7tfIHDgY5hvD0U1ungrbNZPeLEcIBWpxCQ>
<xmx:f2pwYQwGfU3CZv2bU5cFKqSXo9x4e3BXWbeTDYvdmja_L107sOcn-w>
<xmx:f2pwYW73oM3kHZWUbU93JyQsb3fV6nLd4DXHMCQmiF0ggjZGz2pj5w>
<xmx:f2pwYcdxehNBoohBynWUBbo7QT59x5XuYlNXp_d18k5qheKeyEXBZg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
20 Oct 2021 15:14:05 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@nvidia.com>
Cc: dev@dpdk.org, Zhang Yuying <yuying.zhang@intel.com>,
Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Lior Margalit <lmargalit@nvidia.com>,
Ananyev Konstantin <konstantin.ananyev@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 20 Oct 2021 21:14:04 +0200
Message-ID: <4373240.4fSUipx5XS@thomas>
In-Reply-To: <CACZ4nhupXECaxu7r54FVE3g3BzPxarHPUBGzqsof+-HawBxfMA@mail.gmail.com>
References: <20210727034204.20649-1-xuemingl@nvidia.com>
<20211020075319.2397551-5-xuemingl@nvidia.com>
<CACZ4nhupXECaxu7r54FVE3g3BzPxarHPUBGzqsof+-HawBxfMA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable
shared Rx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
20/10/2021 19:29, Ajit Khaparde:
> On Wed, Oct 20, 2021 at 12:54 AM Xueming Li <xuemingl@nvidia.com> wrote:
> >
> > Adds "--rxq-share=X" parameter to enable shared RxQ,
You should end the sentence here.
> > share if device
> > supports, otherwise fallback to standard RxQ.
> >
> > Share group number grows per X ports.
Do you mean "Shared queues are grouped per X ports." ?
> > X defaults to MAX, implies all
> > ports join share group 1. Queue ID is mapped equally with shared Rx
> > queue ID.
> >
> > Forwarding engine "shared-rxq" should be used which Rx only and update
> > stream statistics correctly.
I suggest this wording:
"
A new forwarding engine "shared-rxq" should be used for shared Rx queues.
This engine does Rx only and update stream statistics accordingly.
"
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
[...]
> + printf(" --rxq-share: number of ports per shared rxq groups, defaults to MAX(1 group)\n");
rxq -> Rx queue
Is MAX a special value? or should it be "all queues"?
Note: space is missing before the parenthesis.
[...]
> > +* ``--rxq-share=[X]``
> > +
> > + Create queues in shared Rx queue mode if device supports.
> > + Group number grows per X ports.
Again I suggest "Shared queues are grouped per X ports."
> > + X defaults to MAX, implies all ports
> > + join share group 1. Forwarding engine "shared-rxq" should be used
> > + which Rx only and update stream statistics correctly.
>
> Did you mean "with Rx only"?
> Something like this?
> "shared-rxq" should be used in Rx only mode.
>
> If you say - "the Forwarding engine should update stream statistics correctly",
> I think that is expected anyway? So there is no need to mention that
> in the guide.
I suggested a wording above.