From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DB09A00C5; Mon, 14 Feb 2022 15:00:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEA70410FD; Mon, 14 Feb 2022 15:00:36 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B9BD24067E for ; Mon, 14 Feb 2022 15:00:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644847235; x=1676383235; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=W6Zx/nBB09RV/CP4Za49MxqhyUvGCFfP4h1YJ5u3YLw=; b=GTPcd4x9UcbRuBlRHYJ3BgEXjHS2/PMpLuYiaziAniXZ9ax6IhLJ2VPv c6POruujKViQsdOOrjrZbbfHtZBuU1FRkN6Hg0T03v8FsDrazdv3Sng5M Bgq7SnmtQgCF0xRcf0reTOgeXgMVWVjadiOQIZBMg2dcsDi0NRfrIob2W XMVYEM/CR4W/R7Mw6m3H47lE4gv/mAj4g4AkeUGPjkFFjZnSPsA0CcDIT qwQ85Y97yvGZq3wNktfP9K1b2kmNhxEM11Hm/ohY7mNtQ2fKHRWFIFSzF Jid/G5GE9fSq1S+HLEFO9u2XnqTAlgUm56SU69YIGA3zuB26CFBTaGvX0 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="274663278" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="274663278" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 06:00:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="495640273" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 14 Feb 2022 06:00:23 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 06:00:23 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 06:00:23 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 06:00:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9I2CWebhtjh2foMYxdcHyLMKjf2t5WkuXHm+hLXZN6L5rp8YJpBsrVOQLKveGI9tkizdOvxvkI3OecNNV2L9qqGKmett6dS1ygdjDXQMVVkLhlObtKj73enjjU15zcMrI/rjvKFvyIg266ptmI/ABrDLTRyrYmxk8AdYfqhffXFNHW3pBKFIwsOAPzFhc6PO0vnWQnD+pP9UOapVWNUni9WrMQg7/3LSUOpdNbThPTRljgC3pfolmVPtRfUXa/07IPLe1JOPUciEo+oaGN39uXjjKaQr03P3HklHkFdljU6D/6hphKiFNgjgIDzOwjo4E6MCy8C7d02hZ2ru9CjTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQAM5ksMfLnNPlQm9Yuhd1VdaXkt/lauaIKPMnlL7uU=; b=f20wf/6fEH/kZchp/5t+zraIFPZPBUyaAqPokH4i1XmPGwUCzarjbYQB9/BO5G0s8QB4n/Inh7i7Y8G1Gk4OjDusa+e/uD4cdbx6i7fdlJcNu1+YQ+ZY06hJZIzkeczSTs0E6ap0MWoASnJBnr96GxIfCtSi1SZV2fqBLXi1AxzyuZDdGZYvz4XJdgP8rio9/1N0Oc2gTTXlZ9bWxiOv41F6hcevMgPDkUWeq8Olfl6n8my8KEcPI4QjLK0mEPgMDsQjqCRLeBX8qnkTWec/+CGAVHaSoDfzhsM7jISc/CWJsCnmNqiiijQzLWLV0HvMJ5GXXsJmO1dQavoylqd70g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH2PR11MB4392.namprd11.prod.outlook.com (2603:10b6:610:3e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 14:00:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 14:00:20 +0000 Message-ID: <4373c374-ea96-32b1-2954-9aca39e194db@intel.com> Date: Mon, 14 Feb 2022 14:00:15 +0000 Content-Language: en-US To: John Miller , CC: References: <20220119191255.273988-ed.czeck@atomicrules.com> <20220211113935.303366-1-john.miller@atomicrules.com> From: Ferruh Yigit Subject: Re: [PATCH v2 1/3] net/ark: add device capabilities record X-User: ferruhy In-Reply-To: <20220211113935.303366-1-john.miller@atomicrules.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0245.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 676b4455-3b31-419d-2c30-08d9efc2565f X-MS-TrafficTypeDiagnostic: CH2PR11MB4392:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QxopXcgjyw1Mn7o7IMyyAE4+kPwCINdmfMBcgxp2NiPkMmKBOeDOHHg4wp8mY4ICs8x60LJxELHnP1ziLBnLMzKBZjX/RmxG6s45qdK9HPewYLIJwVO4BE0Q0S1qtsYAkRlMh+fpAlXnfk5urEMJcoZMH3BISaFecvrNWleLBQYkczxvdtzinroi2j017nQu2HAmkkQid9GdGpqipiySHyuJjSfZlJx2++5pmMc4PAVdKtehp0Q7lleG9Ozj8wK8sD6RZJhzblcevV57C0Viz2HmuzmblbsOFLTvNlMUswv2IdyCEpINCHSx/nspnbauQErU6cEJ2e1tAj6cNZdxJ2mb+iE6FnVKwgBNwoPwe/t6wa2D9voGtDeoe0iJtgZ502iwdju0rcCtxjkp/6m9XW747SvY18NHkvxR6iLnGoQpD9Jz2gSwxcJfHDwdVUfNhti2mpvesptHjyPXQTG6HBRYA/KRFL/a4LEjrAKkARDVWfdD1JzrryzORfv12WTI+cRQWk+E6mTaaFJRVInOS3LiHuII6PIIjzg1nqx1eHHg+5fs/7+ZuzgKjt7eVTNHrUkmhYrdBkdOCODVH8eED12I5UJzE4VlvGytbJUq/uGZxFKGixlrWAhGoE1TO8I92TKIIEVRZCcxVjukvpMDpQWB+wsXOkVnZdCShD620mWT50TJ0KlZ8jJShOX98hzFCLeOfhxQdTjmQwLk1znbxw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(4326008)(508600001)(66946007)(8676002)(86362001)(6506007)(6666004)(66556008)(8936002)(6486002)(53546011)(316002)(66476007)(36756003)(38100700002)(31696002)(2616005)(186003)(83380400001)(31686004)(2906002)(5660300002)(82960400001)(26005)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Skw5YjYvbnVQVEZFUmJWMTZGcTgwalBIUEE3b20wWkRpRkNiekY3bVlJVy9r?= =?utf-8?B?cDVtY2hYTmdKVDVlMkdlRTBmZ1dmS3ZmUXBmOVlieCtFMkVLN3VjVFIxRXh2?= =?utf-8?B?MFhhWUFXMVJnbU16T3Jzc3VPWHBEQ2hwMm52NVFWR1djYktEUDFkWjN2dVhx?= =?utf-8?B?S0xHTURKczdyS3dPYTBFbmhVcnM4VldJY3c3MnVGZDhHZUpBNzdWUE14RjE5?= =?utf-8?B?V1ZvSUQrZ2t4Rm1kZWh5QTVNVi85WHE3TGhxV29aM3pURGxCOTVna2c3VHZC?= =?utf-8?B?cXUzdDBQTXZzZkI1WnBSbDZKUlQwQWxyenhTUHV1ay8zeWIyMlNlZDdOWjZP?= =?utf-8?B?UlVWaUFFeDFFR2doczJkY1pibTdabUs5MG5CVWU0Uy9pbGxLZUVZN09nNFRN?= =?utf-8?B?aHlwUEttSmJ5ZmVyUmxRK2VGaTQvNDB5TjhNN2xoaEFsbmwvWHpESmlpdHNP?= =?utf-8?B?TTlKNFNkZXN2RGJYWDBzbTYwOGY4b0Z2cGN2dE5Qbm9MV1Q0SzltdWI0a3ZX?= =?utf-8?B?b0RDa1dMa3k5dXdCY2JaY3M3bUtGbFZEWmRKazFuMThtN0xrS2V3dnduemhk?= =?utf-8?B?U1dzbFpndEtUYlZTaG5lQllWd2RKVUVCUlczbTY4dzBCd3IrK1NFSFhUVktR?= =?utf-8?B?REh3THNsaWpCYTF5ZWM0WXlBZitJNlovTW85eWJBVGVFcTFLeEpHeFZZY3Bp?= =?utf-8?B?MXBpK2RQelh2aWwrQldyQm9mVHl5aGZveU5mTEszUE9TMCs0MnNlY29NQktG?= =?utf-8?B?b1Q0ZG1YL0xmWUQwRWZQd2NMNnNHRmtmSGQ0dEVOV05TdEp1dUYzdkNOZmlr?= =?utf-8?B?ZlRkcGtIcWRVVW1IaEloZ1h3MWtHT3pBRWRZTUNWbXZUOGxIbHNqb2wrRmxG?= =?utf-8?B?dUczaW5jTEtiY0F4T2hsMjZndlBmSVlNdXdwQVd6aDAyU25YVlNZQlNFT21t?= =?utf-8?B?L3BWbDJLVXRWRE9QMytnbkp2U1FVR29YbGNNc0JBalZzYm4rN0x4NG5MWXlU?= =?utf-8?B?Yk9EQjduRnRLc0F4Qks1VjM3WlJYRHcvSjI2ZUIyWGRpYWhweE93SGI5N2Rk?= =?utf-8?B?K2YxL3FNMGRxOG5LVi9ncVlkWExhd1RpZGxPczgzUXg3YUFRdG5GVEdnNWln?= =?utf-8?B?SkQ3U2d6YTVKcEYyNnFBNW5Ra3M1NGl5cnUrVjA3Yi9JS0NXZnpUNFV6dmFM?= =?utf-8?B?aDVURTJBa2VINDFzY1RuQWdGSUhhVUlVQTZyOWJnRDU2NU05eW9uMmVHeHE4?= =?utf-8?B?VlhycFVHVGNGWmpJSjRUbU1TWGMrYk1qMTRyZ2dMNFVtVTEvenJtR2g1Y05T?= =?utf-8?B?Z3hwdUlYRzUraWU5U2NXamkvZm1zZUJBa1FSRFNEV1NTYjhVTHdSNkJvZE1o?= =?utf-8?B?VnJmRkVkODlSYTJmZkhFaDhGQkU2dnRyemdTZFh0d0VIQisxTXphcEo4WG1w?= =?utf-8?B?a0RkT1FrSHdvYmsxSVYxZnJxUjNqTjBkd3VWN3F3eDlWZ1kyQTRCMXRheXly?= =?utf-8?B?aFlrbVlpanY3K0ZPYnFOQVlBbDJpdHJ3YVJrWStGOFpmRVZsUkE1SjdHcUc5?= =?utf-8?B?M2JXS1F2V3RzNnJLb3JWc3l5R3ZMT3BnbHpUQWxLYmo2RW9OUXhWVmQ2Q0xV?= =?utf-8?B?RmFZQ1N2SW5xandJZ3FKNzhlRmVVQUhiKytwZ2lPUWFtMkFLZXFaQ2xPc0M1?= =?utf-8?B?MzlpSjRhZ0JybWxTRHpaS3lTNTdUT3QxU0YzdUN5eUVpa1JtQ0YxUkN0UFF2?= =?utf-8?B?OFo5Z0lLb2dqOHZQdE5OWkRtR3VsSzFheEgzWExOVUhTaWtIUXNEcXdDeTds?= =?utf-8?B?K3pYY3N0VVk2MG1kTm1TV1l4OG00NjVaeEs1eS9VREJsNURBbjdoYkJadWZK?= =?utf-8?B?anllSGN0SDdJdGUzcHZNQVZNc2dyUjIrMmEyeENLUzFwdFF2Z1NCV0FwZlBj?= =?utf-8?B?WkZmUThDOGQ5Rm40Qms0TE5NUnpsdmk4TVRyVU81ZTVpQURHdzJ0VUhRWUI1?= =?utf-8?B?VDJBcTVVVU9YbzdDUGRkK0toTTFTTEVsMFMzRmtwRjIzelY4RXYrY0U4eERP?= =?utf-8?B?Z1pYeFRMWVZsVlZLcDlIUkRyVXYwT3hJNDF1NEpqeHV3Y0MwQ29VNFNja211?= =?utf-8?B?bGxrM0I4clFEL1I5OEg4VHNXR1VKMTNQMmlXRVhWdW1YUjhHWW94MSsvendk?= =?utf-8?Q?fgQSHhCOV2DvEChHXulTvV4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 676b4455-3b31-419d-2c30-08d9efc2565f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:00:20.4373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: suWT6E6LFa/9oZAm91nws1YE6XEhfnCtMXPLwrrOmHHHN2wT4NKFqv6Qbo9L6x66RKi403bMfIM9+q090VLhTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4392 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2022 11:39 AM, John Miller wrote: > Add a device capabilities record for supported features. > Certain variants require that PCIe read-requests be correctly > throttled. This is called "rqpacing" in Arkville, and has to do > with credit and flow control on certain Arkville implementations. > > Signed-off-by: John Miller > > --- > v2: > - Improved code readability and comments. > --- > drivers/net/ark/ark_ethdev.c | 88 +++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 17 deletions(-) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > index b618cba3f0..9f5f375174 100644 > --- a/drivers/net/ark/ark_ethdev.c > +++ b/drivers/net/ark/ark_ethdev.c > @@ -85,17 +85,53 @@ static const char * const valid_arguments[] = { > NULL > }; > > +#define AR_VENDOR_ID 0x1d6c > static const struct rte_pci_id pci_id_ark_map[] = { > - {RTE_PCI_DEVICE(0x1d6c, 0x100d)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x100e)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x100f)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x1010)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x1017)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x1018)}, > - {RTE_PCI_DEVICE(0x1d6c, 0x1019)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)}, > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)}, Here two new device support added, can you please separate it to its own patch? Also is this new device support deserve driver documentation or release notes update?