* [dpdk-dev] [PATCH 1/2] app/testpmd: fix port id type
@ 2018-04-24 5:59 Qi Zhang
2018-04-24 5:59 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix command token Qi Zhang
2018-04-24 11:21 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix port id type Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Qi Zhang @ 2018-04-24 5:59 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu; +Cc: dev, Qi Zhang, stable
Correct couple port id from uint8_t to uint16_t.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
app/test-pmd/cmdline.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0b442c3a6..99dc557a7 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1418,7 +1418,7 @@ cmdline_parse_inst_t cmd_config_speed_all = {
struct cmd_config_speed_specific {
cmdline_fixed_string_t port;
cmdline_fixed_string_t keyword;
- uint8_t id;
+ portid_t id;
cmdline_fixed_string_t item1;
cmdline_fixed_string_t item2;
cmdline_fixed_string_t value1;
@@ -1458,7 +1458,7 @@ cmdline_parse_token_string_t cmd_config_speed_specific_keyword =
TOKEN_STRING_INITIALIZER(struct cmd_config_speed_specific, keyword,
"config");
cmdline_parse_token_num_t cmd_config_speed_specific_id =
- TOKEN_NUM_INITIALIZER(struct cmd_config_speed_specific, id, UINT8);
+ TOKEN_NUM_INITIALIZER(struct cmd_config_speed_specific, id, UINT16);
cmdline_parse_token_string_t cmd_config_speed_specific_item1 =
TOKEN_STRING_INITIALIZER(struct cmd_config_speed_specific, item1,
"speed");
@@ -11846,7 +11846,7 @@ struct cmd_config_l2_tunnel_eth_type_result {
cmdline_fixed_string_t port;
cmdline_fixed_string_t config;
cmdline_fixed_string_t all;
- uint8_t id;
+ portid_t id;
cmdline_fixed_string_t l2_tunnel;
cmdline_fixed_string_t l2_tunnel_type;
cmdline_fixed_string_t eth_type;
@@ -11868,7 +11868,7 @@ cmdline_parse_token_string_t cmd_config_l2_tunnel_eth_type_all_str =
cmdline_parse_token_num_t cmd_config_l2_tunnel_eth_type_id =
TOKEN_NUM_INITIALIZER
(struct cmd_config_l2_tunnel_eth_type_result,
- id, UINT8);
+ id, UINT16);
cmdline_parse_token_string_t cmd_config_l2_tunnel_eth_type_l2_tunnel =
TOKEN_STRING_INITIALIZER
(struct cmd_config_l2_tunnel_eth_type_result,
@@ -11981,7 +11981,7 @@ struct cmd_config_l2_tunnel_en_dis_result {
cmdline_fixed_string_t port;
cmdline_fixed_string_t config;
cmdline_fixed_string_t all;
- uint8_t id;
+ portid_t id;
cmdline_fixed_string_t l2_tunnel;
cmdline_fixed_string_t l2_tunnel_type;
cmdline_fixed_string_t en_dis;
@@ -12002,7 +12002,7 @@ cmdline_parse_token_string_t cmd_config_l2_tunnel_en_dis_all_str =
cmdline_parse_token_num_t cmd_config_l2_tunnel_en_dis_id =
TOKEN_NUM_INITIALIZER
(struct cmd_config_l2_tunnel_en_dis_result,
- id, UINT8);
+ id, UINT16);
cmdline_parse_token_string_t cmd_config_l2_tunnel_en_dis_l2_tunnel =
TOKEN_STRING_INITIALIZER
(struct cmd_config_l2_tunnel_en_dis_result,
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH 2/2] app/testpmd: fix command token
2018-04-24 5:59 [dpdk-dev] [PATCH 1/2] app/testpmd: fix port id type Qi Zhang
@ 2018-04-24 5:59 ` Qi Zhang
2018-04-24 11:21 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix port id type Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Qi Zhang @ 2018-04-24 5:59 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu; +Cc: dev, Qi Zhang, stable
Correct token for queue start stop command.
Fixes: 5f4ec54f1d16 ("testpmd: queue start and stop")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 99dc557a7..ebf6ffb22 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2271,7 +2271,7 @@ cmdline_parse_inst_t cmd_config_rxtx_queue = {
.data = NULL,
.help_str = "port <port_id> rxq|txq <queue_id> start|stop",
.tokens = {
- (void *)&cmd_config_speed_all_port,
+ (void *)&cmd_config_rxtx_queue_port,
(void *)&cmd_config_rxtx_queue_portid,
(void *)&cmd_config_rxtx_queue_rxtxq,
(void *)&cmd_config_rxtx_queue_qid,
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix port id type
2018-04-24 5:59 [dpdk-dev] [PATCH 1/2] app/testpmd: fix port id type Qi Zhang
2018-04-24 5:59 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix command token Qi Zhang
@ 2018-04-24 11:21 ` Ferruh Yigit
2018-04-24 11:23 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-04-24 11:21 UTC (permalink / raw)
To: Qi Zhang, wenzhuo.lu, jingjing.wu; +Cc: dev, stable
On 4/24/2018 6:59 AM, Qi Zhang wrote:
> Correct couple port id from uint8_t to uint16_t.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
For Series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-24 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 5:59 [dpdk-dev] [PATCH 1/2] app/testpmd: fix port id type Qi Zhang
2018-04-24 5:59 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix command token Qi Zhang
2018-04-24 11:21 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix port id type Ferruh Yigit
2018-04-24 11:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).