DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, Fan Zhang <roy.fan.zhang@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Yuan Peng <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS
Date: Sun, 05 Aug 2018 22:08:28 +0200	[thread overview]
Message-ID: <4382199.Nx38v1RVeE@xps> (raw)
In-Reply-To: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com>

31/07/2018 16:49, Cristian Dumitrescu:
> Fix for RSS issue triggered by latest changes in ethdev layer.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Collected agreements:
    Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
    Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
    Tested-by: Yuan Peng <yuan.peng@intel.com>

But 3 things are missing:
	- The issue is not described
	- The fix is not explained (you chose to mask unsupported RSS fields)
	- There is no Fixes line, I guess this one:
		Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")

Please send a v2

      parent reply	other threads:[~2018-08-05 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 14:49 Cristian Dumitrescu
2018-07-31 14:53 ` Zhang, Roy Fan
2018-07-31 14:53 ` Ananyev, Konstantin
2018-08-02  7:03 ` Peng, Yuan
2018-08-05 20:08 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4382199.Nx38v1RVeE@xps \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).