* [dpdk-dev] [PATCH] fm10k: fix clang unused function error
@ 2015-02-18 18:07 Jeff Shaw
2015-02-18 18:39 ` Wiles, Keith
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Shaw @ 2015-02-18 18:07 UTC (permalink / raw)
To: dev
This commit fixes the following error which was reported when
compiling with clang by moving the function inside an
RTE_LIBRTE_FM10K_DEBUG_RX ifdef block.
error: unused function 'dump_rxd'
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
lib/librte_pmd_fm10k/fm10k_rxtx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_pmd_fm10k/fm10k_rxtx.c b/lib/librte_pmd_fm10k/fm10k_rxtx.c
index f6768f0..83bddfc 100644
--- a/lib/librte_pmd_fm10k/fm10k_rxtx.c
+++ b/lib/librte_pmd_fm10k/fm10k_rxtx.c
@@ -41,11 +41,9 @@
#define rte_packet_prefetch(p) do {} while (0)
#endif
+#ifdef RTE_LIBRTE_FM10K_DEBUG_RX
static inline void dump_rxd(union fm10k_rx_desc *rxd)
{
-#ifndef RTE_LIBRTE_FM10K_DEBUG_RX
- RTE_SET_USED(rxd);
-#endif
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
@@ -62,6 +60,7 @@ static inline void dump_rxd(union fm10k_rx_desc *rxd)
PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
}
+#endif
static inline void
rx_desc_to_ol_flags(struct rte_mbuf *m, const union fm10k_rx_desc *d)
--
2.1.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix clang unused function error
2015-02-18 18:07 [dpdk-dev] [PATCH] fm10k: fix clang unused function error Jeff Shaw
@ 2015-02-18 18:39 ` Wiles, Keith
2015-02-24 2:12 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Wiles, Keith @ 2015-02-18 18:39 UTC (permalink / raw)
To: Shaw, Jeffrey B, dev
On 2/18/15, 12:07 PM, "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com> wrote:
>This commit fixes the following error which was reported when
>compiling with clang by moving the function inside an
>RTE_LIBRTE_FM10K_DEBUG_RX ifdef block.
>
>error: unused function 'dump_rxd'
>
>Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Acked-by: keith.wiles@intel.com
>---
> lib/librte_pmd_fm10k/fm10k_rxtx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/lib/librte_pmd_fm10k/fm10k_rxtx.c
>b/lib/librte_pmd_fm10k/fm10k_rxtx.c
>index f6768f0..83bddfc 100644
>--- a/lib/librte_pmd_fm10k/fm10k_rxtx.c
>+++ b/lib/librte_pmd_fm10k/fm10k_rxtx.c
>@@ -41,11 +41,9 @@
> #define rte_packet_prefetch(p) do {} while (0)
> #endif
>
>+#ifdef RTE_LIBRTE_FM10K_DEBUG_RX
> static inline void dump_rxd(union fm10k_rx_desc *rxd)
> {
>-#ifndef RTE_LIBRTE_FM10K_DEBUG_RX
>- RTE_SET_USED(rxd);
>-#endif
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
>@@ -62,6 +60,7 @@ static inline void dump_rxd(union fm10k_rx_desc *rxd)
> PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> }
>+#endif
>
> static inline void
> rx_desc_to_ol_flags(struct rte_mbuf *m, const union fm10k_rx_desc *d)
>--
>2.1.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix clang unused function error
2015-02-18 18:39 ` Wiles, Keith
@ 2015-02-24 2:12 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-02-24 2:12 UTC (permalink / raw)
To: Shaw, Jeffrey B; +Cc: dev
> >This commit fixes the following error which was reported when
> >compiling with clang by moving the function inside an
> >RTE_LIBRTE_FM10K_DEBUG_RX ifdef block.
> >
> >error: unused function 'dump_rxd'
> >
> >Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>
> Acked-by: keith.wiles@intel.com
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-24 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 18:07 [dpdk-dev] [PATCH] fm10k: fix clang unused function error Jeff Shaw
2015-02-18 18:39 ` Wiles, Keith
2015-02-24 2:12 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).