From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>, dev@dpdk.org
Cc: harry.van.haaren@intel.com, gaetan.rivet@6wind.com,
thomas@monjalon.net, mattias.ronnblom@ericsson.com,
bruce.richardson@intel.com, radu.nicolau@intel.com,
ciara.power@intel.com, brian.archbold@intel.com
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix shared build for make
Date: Fri, 9 Nov 2018 22:19:36 +0000 [thread overview]
Message-ID: <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> (raw)
In-Reply-To: <20181107181018.80224-1-kevin.laatz@intel.com>
On 11/7/2018 6:10 PM, Kevin Laatz wrote:
> Currently, telemetry is not working for shared builds in make.
>
> The --as-needed flag is preventing telemetry from being linked as there are
> no direct API calls from the app to telemetry. This is causing the
> --telemetry option to not be recognized by EAL.
> Telemetry registers it's EAL option using the RTE_INIT constructor. Since
> EAL's option parsing is done before the plugins init, the --telemetry
> option isn't registered at the time of parsing, and as a result, the
> --telemetry option is not being recognized.
>
> This patch fixes this issue by explicitly linking telemetry to the
> application by setting the "--no-as-needed" flag for the library in
> mk/rte.app.mk.
>
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
>
> Reported-by: Yanjie Xu <yanjie.xu@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2018-11-09 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 18:10 Kevin Laatz
2018-11-07 21:08 ` Thomas Monjalon
2018-11-08 11:59 ` Laatz, Kevin
2018-11-09 22:19 ` Ferruh Yigit [this message]
2018-11-12 0:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=brian.archbold@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=kevin.laatz@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=radu.nicolau@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).