From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 0EE785323 for ; Mon, 14 Mar 2016 23:22:29 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id l68so2315581wml.1 for ; Mon, 14 Mar 2016 15:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KYFFViwb/jY+jLEIIGqMcmgBxNs9hY8OqB2rTaeDlzg=; b=UM8cUbHjJu3B67jatQHop4+JRlMYS9d/0IBWp4PhYmw4puEn6EQxyu+9PHtkz0uSlH 2cpbVTcpTsMVQTtOYl9LqtErHlW++nlwPernNflJY2W2RI5Q/ch6pZLhHPuX5zEF4PWi jl/BgOlezMewhFH++2Y2CXyYQ2UhBRg2PYS88UUhvZ29K5I+AIMj25uraOR/pzc8+UFE +QsoP7h1sMQeanHw3Yt3atW/WSzgklcSiN0Nvr02hSYzQoc/RzqdXeP2H+nWxI87m/EM l6QlWi7kt/rbiem5BC39h1I/rFdUbTmU5fGEYdNSg+mHbZASNGH1JKSCQrxRRSxrP5v/ HsKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=KYFFViwb/jY+jLEIIGqMcmgBxNs9hY8OqB2rTaeDlzg=; b=cDqFv7WBTa1oCY94ct/CWf2gBMPPIFO/sGvb81VFQtsBvYTwM5w7Ef/VAbW8pPiybS LlYYBNQaLDqsYDxEznSzhKHt3wro8kNlWmebtx87+/D6RHBoG/zDEznI9zVfQw/HjidK 7O6yQrrJ800fu853zY/OYqcUOHtXiUDNKT8soKS3LW3cIA28ebzNA9mPMBcJSnfWvPQE KnDk/tSjnFkao+M5EchnyGDLpxuyNyuN+qwWxP0PZqw8S01PfNSQt5wNv8vVP99Ky7ci YhA2rquzp/S/4ta0XeO/hn6fBItDEKl4vXAWEie3twzX44bAnpqNyvG568Bh/bgp2Uie 3xBw== X-Gm-Message-State: AD7BkJK8A7GyqfdYN65vM45xeKCX/hpSenU6ZK67/3FBP62auKDO8X9ztDpuD96NkQDZ/5+M X-Received: by 10.28.226.212 with SMTP id z203mr20713997wmg.9.1457994148893; Mon, 14 Mar 2016 15:22:28 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id pd1sm24139229wjb.19.2016.03.14.15.22.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Mar 2016 15:22:27 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, David Marchand Date: Mon, 14 Mar 2016 23:21:04 +0100 Message-ID: <4392228.eN2PaL5BSa@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 22:22:29 -0000 2016-03-10 08:43, David Marchand: > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > wrote: > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > a random upper 32 bit feature bits, as the following io port read reads > > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1 > > (the 32th bit) for legacy virtio, which is obviously wrong. > > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API") > > > > Cc: David Marchand > > Signed-off-by: Yuanhan Liu > > Argh, good catch. > Relooked at my patch, this should be the only bug (of this kind ;-)). > > Reviewed-by: David Marchand Applied, thanks