From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 730A8A055B; Tue, 25 Feb 2020 21:27:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48A011BF8D; Tue, 25 Feb 2020 21:27:54 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 100C22C4F for ; Tue, 25 Feb 2020 21:27:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E494722083; Tue, 25 Feb 2020 15:27:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 25 Feb 2020 15:27:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=COvuv/h5fOPoi0FYbAy9w4ulfmt48lz2bIyRHxG9TnE=; b=ad4SR0hPAC7Z nNHhezX7+ogC9DPsMx1LApJnWc6reLkjzlVCF964U9WBluhpM4S7KtHTSmy4wA/v zJRZ1UqgHyy5wtAXYB5M9m2W4kZLrdOBx+aGLrtUu+3quDPXfyqux/vTfbbl8FNf HiWPsMOp2/p8QCfxg5fg+8PTRgkJQkw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=COvuv/h5fOPoi0FYbAy9w4ulfmt48lz2bIyRHxG9T nE=; b=NhGQJW1mqAFLMm3AeumUFb/vidIjeXTge5MM+CvsFN+dh3ZvJIwpEPqs4 VbZeMIRmOqQdb9+QIi3UojQLITsSJPcSFKy7r4pFBSd9KoTgGUwQhPnUbcFa7F8C Y6doLnl+7Wz6HXhjLPH/f2RE2WjHN9Kujnz4U695SPexkhpCKCG25qawHzo//TIM fn2IBpAvlPC0ynrNmjay4hRe6LezSHmHKt5QZbcqLyGcn36yKNj8XXdHW7gefrsu w29qE9RfDNn+1gPBXpZlmFSTak/I86UHJgDHnQqnBT30W9GAe7FEGsIuK+5oKpeP PccIjybi7HS60rUC5yNAmPj6cZC2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledvgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrvddthedrudduiedrudekjeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (187.116.205.77.rev.sfr.net [77.205.116.187]) by mail.messagingengine.com (Postfix) with ESMTPA id A47AB3280059; Tue, 25 Feb 2020 15:27:47 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Sean Morrissey Cc: dev@dpdk.org Date: Tue, 25 Feb 2020 21:24:27 +0100 Message-ID: <43963916.XUcTiDjVJD@xps> In-Reply-To: <20200224153001.3941073-1-ferruh.yigit@intel.com> References: <20200224120227.454547-1-ferruh.yigit@intel.com> <20200224153001.3941073-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] devtools: export title syntax data for check-git-log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/02/2020 16:30, Ferruh Yigit: > From: Sean Morrissey > > Moved title syntax to a separate file so that it improves code > readability and allows easy addition. > > Also logic changed from checking for bad pattern to checking good > pattern which documents the expected syntax more clearly, and does not > have gaps in the checks. > > Signed-off-by: Sean Morrissey > Signed-off-by: Ferruh Yigit > --- > +words="$selfdir/words-case.txt" > +for word in $(cat $words); do I think we should exclude comments in the words file. > + bad=$(echo "$headlines" | grep -iw $word | grep -v $word) > + if [ "$word" = "Tx" ]; then > + bad=$(echo $bad | grep -v 'OCTEON\ TX') > + fi We could try to manage such false positive automatically by excluding valid patterns while patterns list is iterated. If OCTEON TX is before Tx in the list, no confusion is possible. > + for bad_line in $bad; do > + bad_word=$(echo $bad_line | cut -d":" -f2 | grep -io $word) The cut will ignore anything after a second colon. Should not happen but a possible minor issue. > + if [ -n "$bad_word" ]; then > + printf "Wrong headline case:\n\"$bad_line\": $bad_word --> $word\n" > + fi > + done > +done I think it is good enough to be merged. We can adress above improvements in a separate patch. Applied, thanks