From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 69ED323C
 for <dev@dpdk.org>; Wed,  2 May 2018 12:06:13 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id DCE63227B8;
 Wed,  2 May 2018 06:06:12 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 02 May 2018 06:06:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=dJVe3vbKt69jTkAEO9iC1If4VL
 WYG34r/8NW27nD2HU=; b=qm9WZXWwzfydLhfRvpam9UxaQ8G1/+v5fDXklt+NUW
 7cAyQeZGKF7gdMrUD39dbACK7EFDJK/ACF/GZ/6mK8d0RGyPZwMdUVmPXsl/D0pH
 +IZFafQJMEv29vePzihPU1GtE5kGmCARS293PVCDdktl4HaFq5XvtZXwoWJM9oWN
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=dJVe3v
 bKt69jTkAEO9iC1If4VLWYG34r/8NW27nD2HU=; b=c34VRbmAya9ERS0wYGEAWq
 QJGSFCIedxUhOXpC/xpCC6SbjOHAtcr/GkMY5ShgTPHv9zvM0pHXx0ReCYy2cu92
 r0tjrECEcFkELAW5Qi7J80viJqJcs0/HI0SAamaV8gIcGepOpWsVZSay6ehPqBub
 ideINmqJCJSzQFxzn+invg8XwdTcykukdv972MuASjZrpx8nAkJBVNTyc5vZqx6A
 ioi/wd9dzPXXkOhBfnXIBsws53OEWXBmjh0lRxmAs2WWNu+JS/2vUuNZJqiIISaR
 LtM+wyp9JQ+ne2R19Fzii7gi4BMcUTUUekJ7SQONDfdObPd6cRhG9Q0aCjXz5+CQ
 ==
X-ME-Sender: <xms:lI3pWuwxE7iGME9X2p9a_OWVTZT6BNiqvsM2AO9hXzY4KTCfcxgdCA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3F092E5097;
 Wed,  2 May 2018 06:06:12 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Date: Wed, 02 May 2018 12:06:11 +0200
Message-ID: <4396631.OICrUNRNKa@xps>
In-Reply-To: <VI1PR05MB16782ECA2529512AEB2A6441AC800@VI1PR05MB1678.eurprd05.prod.outlook.com>
References: <20180501133343.125260-1-ferruh.yigit@intel.com>
 <68310139-6baf-baab-bbe9-3da0883960bc@intel.com>
 <VI1PR05MB16782ECA2529512AEB2A6441AC800@VI1PR05MB1678.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 May 2018 10:06:13 -0000

02/05/2018 11:58, Xueming(Steven) Li:
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Or as Xueming suggested, we can take rss_hf config as best effort and not return error at all.
> > 
> > I think this forces PMDs to have up-to-date flow_type_rss_offloads values, is there any other benefit?
> > What was the initial motivation to add error return on this check?
> 
> The original idea is to add rss_hf check on mlx5 PMD, while it looks more generic
> to move the check to ethdev api from discussion[1].
> 
> [1] http://www.dpdk.org/ml/archives/dev/2018-April/095136.html

I think it is not correct to not return an error when the app
request an offload which is not supported.

Do we agree to work on PMDs and applications to fix this offload compliance?
And submit a deprecation notice to return an error in a later release?