From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A07372BDD for ; Mon, 5 Dec 2016 15:34:32 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 05 Dec 2016 06:34:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,747,1477983600"; d="scan'208";a="908849088" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2016 06:34:29 -0800 To: Jingjing Wu , dev@dpdk.org References: <1480727953-92137-1-git-send-email-jingjing.wu@intel.com> <1480727953-92137-3-git-send-email-jingjing.wu@intel.com> Cc: helin.zhang@intel.com From: Ferruh Yigit Message-ID: <43a71cb3-f345-0b7d-86d3-571ed2cb540a@intel.com> Date: Mon, 5 Dec 2016 14:34:28 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480727953-92137-3-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/31] net/i40e/base: preserve extended PHY type field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 14:34:33 -0000 On 12/3/2016 1:18 AM, Jingjing Wu wrote: > Prevents 25G PHY types from being disabled when setting > the flow control modes. > > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/base/i40e_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c > index 9a6b3ed..d67ad90 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -1789,6 +1789,7 @@ enum i40e_status_code i40e_set_fc(struct i40e_hw *hw, u8 *aq_failures, > config.abilities |= I40E_AQ_PHY_ENABLE_ATOMIC_LINK; > /* Copy over all the old settings */ > config.phy_type = abilities.phy_type; > + config.phy_type_ext = abilities.phy_type_ext; http://dpdk.org/dev/patchwork/patch/17338/ does something similar in i40e_phy_conf_link(), can you please double check if these two works fine together? Thanks, ferruh