From: Thomas Monjalon <thomas@monjalon.net>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ophirmu@mellanox.com" <ophirmu@mellanox.com>,
"wisamm@mellanox.com" <wisamm@mellanox.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration
Date: Wed, 24 Oct 2018 21:55:15 +0200 [thread overview]
Message-ID: <4409048.vUvRZhrQBt@xps> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D16FD4@IRSMSX107.ger.corp.intel.com>
24/10/2018 17:55, Iremonger, Bernard:
> Hi Thomas,
>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > +/* Pretty printing of ethdev events */
> > +static const char * const eth_event_desc[] = {
> > + [RTE_ETH_EVENT_UNKNOWN] = "unknown",
> > + [RTE_ETH_EVENT_INTR_LSC] = "LSC",
>
> How about replacing "LSC" with "interrupt link status change"
When it is printed, "event" is appended.
So I think "interrupt" is a bit too much.
OK for "link state change"?
> > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state",
> > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset",
> > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox",
> > + [RTE_ETH_EVENT_IPSEC] = "IPsec",
> > + [RTE_ETH_EVENT_MACSEC] = "MACsec",
> > + [RTE_ETH_EVENT_INTR_RMV] = "device removal",
>
> How about replacing "device removal" with "interrupt device removal"
For same reason, I think "device removal" is enough.
It will be printed as "device removal event".
next prev parent reply other threads:[~2018-10-24 19:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 13:41 [dpdk-dev] [PATCH 0/5] app/testpmd: improve attach/detach support Thomas Monjalon
2018-10-24 13:41 ` [dpdk-dev] [PATCH 1/5] app/testpmd: check not detaching device twice Thomas Monjalon
2018-10-24 15:38 ` Iremonger, Bernard
2018-10-24 13:41 ` [dpdk-dev] [PATCH 2/5] app/testpmd: merge ports list update functions Thomas Monjalon
2018-10-24 15:45 ` Iremonger, Bernard
2018-10-24 13:41 ` [dpdk-dev] [PATCH 3/5] app/testpmd: check not configuring port twice Thomas Monjalon
2018-10-24 15:50 ` Iremonger, Bernard
2018-10-24 13:41 ` [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration Thomas Monjalon
2018-10-24 15:55 ` Iremonger, Bernard
2018-10-24 19:55 ` Thomas Monjalon [this message]
2018-10-25 8:54 ` Iremonger, Bernard
2018-10-25 8:58 ` Thomas Monjalon
2018-10-24 13:41 ` [dpdk-dev] [PATCH 5/5] app/testpmd: setup attached ports on probe event Thomas Monjalon
2018-10-24 16:13 ` Iremonger, Bernard
2018-10-24 19:57 ` Thomas Monjalon
2018-10-25 8:58 ` Iremonger, Bernard
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 0/5] app/testpmd: improve attach/detach support Thomas Monjalon
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 1/5] app/testpmd: check not detaching device twice Thomas Monjalon
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: merge ports list update functions Thomas Monjalon
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: check not configuring port twice Thomas Monjalon
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 4/5] app/testpmd: move ethdev events registration Thomas Monjalon
2018-10-25 16:05 ` Iremonger, Bernard
2018-10-25 15:11 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: setup attached ports on probe event Thomas Monjalon
2018-10-25 16:07 ` Iremonger, Bernard
2018-10-26 12:46 ` [dpdk-dev] [PATCH v2 0/5] app/testpmd: improve attach/detach support Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4409048.vUvRZhrQBt@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=ophirmu@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).