From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 449B34C95 for ; Wed, 24 Oct 2018 21:55:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8D66D22089; Wed, 24 Oct 2018 15:55:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 15:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cC2vp6BpZmXx+CadZ1JSfveccU0QYfu73/E3DFXeiEE=; b=gNP9XBWAPSuU Pm8F7pA9JPtXMYqpbdjhdl3sf/8C1ZGZAmMw95OzT+Kz7Vlb+FGFO+9QOHQfM51n pLrXcrAbn5XDRSGQ8osrs0ehUKXCJsF60ZrO6qHDyNK1VsfJjCuqhaOJriOgj5Vz GBV7C6Yc5NjN/z/nI+VPlVV/eDHGpnQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cC2vp6BpZmXx+CadZ1JSfveccU0QYfu73/E3DFXei EE=; b=YB9yTZ/ir2p86eXPiYXAYV9kPvnMZVmDkxoQehe5R0zzdhjTFN6V6Ubfw 2RnbQWSiaBvWgv1TaAY+kzQWKWTRYYYwF2LksCEXhnS//PZbeQGZeq1OlNRdjN9g 8dgrr1WnyBHmbhMtPJ2rkSZl+Ai04MSPJynD6d2rOSNG566qaPbU5X+kNgdYaFGb 6io9hlclyLHsw5Hl1r6mEhGisTH9cgPjqxC4fBPYbqYMiq/LUxLvGpXwvd+9qAlc k7XWYTyJr6sN6Utrcw9UZPJVpaE7hRLEneLFpuH2uIFRxmTqnrJNOowzdBED6XQW U5h8dDWKEuvDzf5ydTk9phDoMcinw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D016102ED; Wed, 24 Oct 2018 15:55:14 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: "Wu, Jingjing" , "Lu, Wenzhuo" , "dev@dpdk.org" , "ophirmu@mellanox.com" , "wisamm@mellanox.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" Date: Wed, 24 Oct 2018 21:55:15 +0200 Message-ID: <4409048.vUvRZhrQBt@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D16FD4@IRSMSX107.ger.corp.intel.com> References: <20181024134111.26771-1-thomas@monjalon.net> <20181024134111.26771-5-thomas@monjalon.net> <8CEF83825BEC744B83065625E567D7C260D16FD4@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 19:55:16 -0000 24/10/2018 17:55, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > +/* Pretty printing of ethdev events */ > > +static const char * const eth_event_desc[] = { > > + [RTE_ETH_EVENT_UNKNOWN] = "unknown", > > + [RTE_ETH_EVENT_INTR_LSC] = "LSC", > > How about replacing "LSC" with "interrupt link status change" When it is printed, "event" is appended. So I think "interrupt" is a bit too much. OK for "link state change"? > > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state", > > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset", > > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox", > > + [RTE_ETH_EVENT_IPSEC] = "IPsec", > > + [RTE_ETH_EVENT_MACSEC] = "MACsec", > > + [RTE_ETH_EVENT_INTR_RMV] = "device removal", > > How about replacing "device removal" with "interrupt device removal" For same reason, I think "device removal" is enough. It will be printed as "device removal event".