From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 48A1C1BB26 for ; Fri, 27 Oct 2017 00:03:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B9B1820C82; Thu, 26 Oct 2017 18:03:11 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 18:03:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5NORv8vwlqxh+ttnw/aEbRnhOx 99qI7EXUmEeqEo7r4=; b=cbM1arCdDZT0Uefs0/jBbq1wpr+yxmKawGk1MR4CH9 eZeMih/xYiNBu66qpoSiFV+nvPc8teWcGciRTWg6YWCGPjFsWyf55LCeg8QICWGi xsDxcvfjjLKESQoJtaHFjp01t38xZcZPkOv1k+BKAYCfP8oA7BHYo0ZlaiNJ9KEK 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5NORv8 vwlqxh+ttnw/aEbRnhOx99qI7EXUmEeqEo7r4=; b=k8nMEIXYC+mpvGOpJhgefV dc4iyR9irqJ4mY1/xP1phJ3nR/fUvPCrpxyJioQnNu49B/E9sQx2+rfsfknjXWKK h1cqlT4RG5PnOJHiCOf1EFwOGIadAL8aHNpwvsuy0sRaepuMXkRJhn9FkQjN1Hmc boZU+xPV7h5dGK2p+QsY1jMmkJFvrJnMWtu7x41xgZAfot/cpkjUCXO2H4DlNWfS OfP7NKOhXYcaUm2YDW09fh8opY2jHFmV3IbUqLGEjcscZoItCp1RFdzB1MkqUd/A 85+4dDv9Rwaag4tzGjhUclvSoFxb9jMU8YD9ggvt0ATuscJapeMKcMI/J0i55Q/Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6E0962432A; Thu, 26 Oct 2017 18:03:11 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Nikhil Rao Cc: dev@dpdk.org, "Hunt, David" , Konstantin Ananyev Date: Fri, 27 Oct 2017 00:03:10 +0200 Message-ID: <4412880.1l5vTf8byN@xps> In-Reply-To: <20170904125932.GA21808@bricha3-MOBL3.ger.corp.intel.com> References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com> <2295899.BebvH11edl@xps13> <20170904125932.GA21808@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 22:03:12 -0000 04/09/2017 15:02, Bruce Richardson: > Couple of other comments on this code area that should be taken into > account: > 1. the indentation of the asm code looks wrong, and should probably be > fixed to make it more readable. > 2. the comment on the "D" register is wrong as it refers to ebx > 3. the fact that we can't use ebx, and instead use edi and swap twice > should be commented. A patch to fix all these comments would be welcome :) > For the fix itself: > > Acked-by: Bruce Richardson Applied (more than one year after the submission), thanks