From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E681A00C3; Wed, 21 Sep 2022 19:55:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 236AA4281E; Wed, 21 Sep 2022 19:55:47 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by mails.dpdk.org (Postfix) with ESMTP id 6F9F842826 for ; Wed, 21 Sep 2022 19:55:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUeJGRfhA48C2pkD29ysRz1rWiiP+0CEUxcPziW89OCP+x1C0gFYUIEbk+BhADrUJ4/JOtn+kL5nJFOeRfc2KUQLG/ITIFsE1mB0W/NYN4hfCvDi0eG5ikTyygoLApqAedd2W7TUq2oOx5zRDpsKjyKEQetkqTwzQ0hXrRkCuHCvUOIVokNioA8bBf1+50KEC51FCtUacVh6hatoYCuspJgIAEIpa9D/tQd2sU0pszpvGrXFH73BpDZ/rziy1AaslUbzB2xI3H7H9qGQ7HHNQys/abMvCq0BgnjGA0wlu3YQYAFeECTlrrStY8jkwJsh9avq4TCiiI4/4Xdz7t0HZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zSTtN7k/hOkTXBepNUUcQxTPL1ytFX9xVKIceNL8TV0=; b=lK0cscoQKptnvroiTCDJxxhir+SQcdOeCneC/pRqAVfdRqYodKV5goooLkn4kLrNpLs/TDa96BOy8alT14kpU87fwGMksQ10k83ULTbdgFPdO5SqKww0+t4EhrVeGHE40tqOJ075aIqnDMWHAoMvm2Gw1mI4QW5Nv8oDidCbJAE16l8K5fa4L9cvAlZmWvwpb/lvhga0AemVrVpxfhwBNW34KuvdIGFH4cbcgTavVzOeWKSihiZOxfgK6NTubTzdjKPxqDHeCU79vimp7QFYVv0iXOzVBSAn6cXF2ZwUVT+KAjS++OESxz8JrMfX3eX/SN7UrmzCP7cT6JfAcRGuEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=microsoft.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zSTtN7k/hOkTXBepNUUcQxTPL1ytFX9xVKIceNL8TV0=; b=d938DWoIeRKKT+w48Q7mZrVJa85wk/U4BKDjrLhdpIFkn6kO6m7y00t5oAlDGOddUC8nozvyEr8Crnwe79Na8KTiEMzEFY5CWV9b++vL5i9gok+6sOL9bXETd/2IcxbMwy3z9jeeDyFuY6kBBc3auVP/U6GMHUY2+7H/ycrzui8= Received: from BN0PR04CA0021.namprd04.prod.outlook.com (2603:10b6:408:ee::26) by CH2PR02MB7032.namprd02.prod.outlook.com (2603:10b6:610:81::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 17:55:43 +0000 Received: from BN1NAM02FT054.eop-nam02.prod.protection.outlook.com (2603:10b6:408:ee:cafe::ef) by BN0PR04CA0021.outlook.office365.com (2603:10b6:408:ee::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16 via Frontend Transport; Wed, 21 Sep 2022 17:55:43 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT054.mail.protection.outlook.com (10.13.2.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 17:55:43 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 21 Sep 2022 18:55:42 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 21 Sep 2022 18:55:42 +0100 Envelope-to: ferruh.yigit@xilinx.com, longli@microsoft.com, dev@dpdk.org, sharmaajay@microsoft.com, sthemmin@microsoft.com Received: from [10.71.194.74] (port=29261) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ob3wk-00074L-AA; Wed, 21 Sep 2022 18:55:42 +0100 Message-ID: <4413343c-8b1e-e447-b504-c0d44dd6b467@amd.com> Date: Wed, 21 Sep 2022 18:55:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [Patch v8 01/18] net/mana: add basic driver with build environment and doc Content-Language: en-US To: , Ferruh Yigit CC: , Ajay Sharma , Stephen Hemminger References: <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> <1662674189-29524-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1662674189-29524-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1NAM02FT054:EE_|CH2PR02MB7032:EE_ X-MS-Office365-Filtering-Correlation-Id: 11b62953-3ca0-4634-e16c-08da9bfa80f7 X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z22gx1cQxHApftJTXNOVrySDxI/DDB8Z1vvQsOC773DtmxMJkObHKkhGJYulxLe5bM//m/ufYjteOZ5tYl/VsqE5IzmUiQfsta2fpWE6beu15GSbpUuDL+NBo0rT5iNZj5OTvX1rZ6wO1NZzDq5A9ZyPQFeyQGdBCtf1mSatwzij7GKgB+Ax8QEaa1o4Lz1s/FLoS/ictto8+r6FWqFz+t44uiuoNvYTqh9vaXDFxDjApldJpQk4D2vQ4g1xVwdlIVFoI0c4NuSaKiv1HlWAiJfsKA+9DDSRal12pxqxICv7sVMG8+lo3g+4jQTvp6M+foMt9vvIYFGmdJaAA0XqXIAUG4iy4+PNYrOhUHnpX+L950dJsBebowWcn/nA8rKgd5V0/I1BwvJXVfH05nB9b8GIVwymCgkH11bb54Y4gDI6qGHytMkGhLd8czkz9KXJtodOkYivECsLpDt2JP2afKZIucNUwVVc7Fvr4iaepwLFJizSZeUPS08YZLCLT8sIn43/6D8KYR5ztyLFWTwMa0h17jl/O0gxfva1G+neZQRbqG+MVtpydG+ia9RfX+0qcgXQ8XC05Xit6JpxE55l5yGPjPK9LS0kNgtgeJARqIzUKsekitmZgS3UXZDlRmU8/cZaTpPPZMTt6gKxrOxVmT0ptsoTtUI5dtRoiU2zfcduX6b3Rv5z+VwQ0KsSYk02imfenprrVzfoZKdYoknwpEWOOP2Grdn93YuSOliJ5yySGkkNggjHCInnFUQkXPpwqM502+d3HsWBmM2NUSpNdF2KJqV5gzuB4gqiu9JBehhynTDBCW4mCiKa5TR8YzaC7U4xvOw696kfT8hUUl7gBg== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(41300700001)(31696002)(498600001)(8936002)(9786002)(86362001)(45080400002)(82310400005)(5660300002)(44832011)(40480700001)(8676002)(110136005)(54906003)(4326008)(316002)(70586007)(70206006)(7636003)(356005)(40460700003)(82740400003)(2616005)(53546011)(47076005)(26005)(336012)(35950700001)(36756003)(31686004)(2906002)(83380400001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 17:55:43.2485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11b62953-3ca0-4634-e16c-08da9bfa80f7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT054.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB7032 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/8/2022 10:56 PM, longli@linuxonhyperv.com wrote: > From: Long Li > > MANA is a PCI device. It uses IB verbs to access hardware through the > kernel RDMA layer. This patch introduces build environment and basic > device probe functions. > > Signed-off-by: Long Li > --- > Change log: > v2: > Fix typos. > Make the driver build only on x86-64 and Linux. > Remove unused header files. > Change port definition to uint16_t or uint8_t (for IB). > Use getline() in place of fgets() to read and truncate a line. > v3: > Add meson build check for required functions from RDMA direct verb header file > v4: > Remove extra "\n" in logging code. > Use "r" in place of "rb" in fopen() to read text files. > v7: > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > v8: > Add clarification on driver args usage to nics guide. > Fix coding sytle on function definitions. > Use different variable names in MANA_MKSTR. > Use MANA_ prefix for all macros. > Use RTE_PMD_REGISTER_PCI in place of rte_pci_register. > Add .vendor_id = 0 to the end of PCI table. > Remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS from dev_flags. > > MAINTAINERS | 6 + > doc/guides/nics/features/mana.ini | 10 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/mana.rst | 69 +++ > drivers/net/mana/mana.c | 728 ++++++++++++++++++++++++++++++ > drivers/net/mana/mana.h | 207 +++++++++ > drivers/net/mana/meson.build | 44 ++ > drivers/net/mana/mp.c | 241 ++++++++++ > drivers/net/mana/version.map | 3 + > drivers/net/meson.build | 1 + > 10 files changed, 1310 insertions(+) > create mode 100644 doc/guides/nics/features/mana.ini > create mode 100644 doc/guides/nics/mana.rst > create mode 100644 drivers/net/mana/mana.c > create mode 100644 drivers/net/mana/mana.h > create mode 100644 drivers/net/mana/meson.build > create mode 100644 drivers/net/mana/mp.c > create mode 100644 drivers/net/mana/version.map Can you please run './devtools/check-meson.py', it complains about 'drivers/net/mana/meson.build'?