From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80E3DA00C4; Thu, 31 Oct 2019 16:29:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F4A91C2E8; Thu, 31 Oct 2019 16:29:52 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0929B1C2E7 for ; Thu, 31 Oct 2019 16:29:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 08:29:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,252,1569308400"; d="scan'208";a="375278145" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.9]) ([10.237.221.9]) by orsmga005.jf.intel.com with ESMTP; 31 Oct 2019 08:29:46 -0700 To: "Wang, Haiyue" , Jerin Jacob Cc: Thomas Monjalon , dpdk-dev , "Ye, Xiaolong" , "Kinsella, Ray" , "Iremonger, Bernard" , "Sun, Chenmin" , Andrew Rybchenko , Slava Ovsiienko , Stephen Hemminger , David Marchand , Jerin Jacob References: <20191015075133.38560-1-haiyue.wang@intel.com> <1811898.7XjjD7ZjLQ@xps> <12001140.UMXFOKstgs@xps> <436fddc9-60cd-48ba-6e13-ed4fa4e7cc8d@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <441515fb-f008-1799-a96d-b969f6879301@intel.com> Date: Thu, 31 Oct 2019 15:29:46 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31/2019 3:07 PM, Wang, Haiyue wrote: >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, October 31, 2019 22:58 >> To: Wang, Haiyue ; Jerin Jacob >> Cc: Thomas Monjalon ; dpdk-dev ; Ye, Xiaolong >> ; Kinsella, Ray ; Iremonger, Bernard >> ; Sun, Chenmin ; Andrew Rybchenko >> ; Slava Ovsiienko ; Stephen Hemminger >> ; David Marchand ; Jerin Jacob >> >> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information >> >> On 10/31/2019 11:16 AM, Wang, Haiyue wrote: >>>> -----Original Message----- >>>> From: Jerin Jacob >>>> Sent: Thursday, October 31, 2019 18:46 >>>> To: Wang, Haiyue >>>> Cc: Yigit, Ferruh ; Thomas Monjalon ; dpdk-dev >>>> ; Ye, Xiaolong ; Kinsella, Ray ; >>>> Iremonger, Bernard ; Sun, Chenmin ; Andrew >>>> Rybchenko ; Slava Ovsiienko ; Stephen >> Hemminger >>>> ; David Marchand ; Jerin Jacob >>>> >>>> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information >>>> >>>>>> 'rte_eth_burst_mode_option_name()' can get "struct rte_eth_burst_mode" as >>>>>> parameter and convert the 'options' to string and combine into single string as >>>>>> a helper function to the applications. >>>>>> >>>>> >>>>> Change: >>>>> const char * >>>>> rte_eth_burst_mode_option_name(uint64_t option) >>>>> >>>>> to: >>>>> int >>>>> rte_eth_burst_mode_option_name(struct rte_eth_burst_mode *mode, char *str) ? >>>> >>>> >>>> Since we are not ready to _remove_ flags in public API and rc2 time is >>>> ticking, probably the following the change >>>> would be enough. IMO, This API can be used only for logging purpose, I >>>> don't want to spend too >>>> many cycles on this discussion. I am leaving the decision to ethdev >>>> maintainers to accommodate >>>> the specifics of adding a string-based alternate options scheme. >>>> >>> >>> Thanks, Jerin. >>> >>>> >>>> [master][dpdk.org] $ git diff >>>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >>>> index c36c1b631..2f9d2c0a7 100644 >>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>> @@ -1272,8 +1272,11 @@ enum rte_eth_burst_mode_option { >>>> * Ethernet device RX/TX queue packet burst mode information structure. >>>> * Used to retrieve information about packet burst mode setting. >>>> */ >>>> +#define RTE_ETH_BURST_MODE_ALT_OPT_SIZE 128 >> >> Should we make it bigger to prevent ABI break just because of this later? Like >> 512 or bigger? >> > > Use 1024 ? > >>>> + >>>> struct rte_eth_burst_mode { >>>> uint64_t options; >>>> + char alternate_options[RTE_ETH_BURST_MODE_ALT_OPT_SIZE]; >>>> }; >>> >>> +1 >>> >> >> +1 >> >> It is not as flexible as getting the size from the PMD but much simpler, both >> for the user and PMD. >> >> And what about dropping the 'rte_eth_burst_mode_option_name()', if >> 'rte_eth_tx_burst_mode_get()' converts the 'options' to text >> ('alternate_options') as Jerin suggested, we can drop it. >> >> So only difference from what Jerin suggested will be keeping 'uint64_t options' >> public for known/limited standardized options, which is currently only for >> vectorization information. > > Since 'struct rte_eth_burst_mode' will be public, how about keep current design for > rte_eth_rx/tx_burst_mode_get() ? What do you mean keep current design, not having a string field in "struct rte_eth_burst_mode"? > > But change 'const char *rte_eth_burst_mode_option_name(uint64_t option)' to > 'int rte_eth_burst_mode_name(struct rte_eth_burst_mode *mode, char *name)' ? > When 'name' is NULL, return the buffer size will be used. If non-NULL, format > all the options. This will reduce the twice PMDs calls: > dev->dev_ops->rx/tx_burst_mode_get > And leave the filled *mode for application. > we need "dev_ops->rx/tx_burst_mode_get" to get information from PMDs, except from 'uint64_t options' the provided information already as string, if the ethdev APIs for these devops converts 'uint64_t options' to string and append to 'alternate_options', application will already have all the string, so won't need this 'rte_eth_burst_mode_option_name()' API anymore.