From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id BC8B81B5F8 for ; Mon, 23 Oct 2017 13:18:16 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id q132so9057634wmd.2 for ; Mon, 23 Oct 2017 04:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=4LfEBcFWA3guoTurZrkLBmYUUG9nybW+jTAI2lFQfeY=; b=XjVX8MNdjlzItAg+dkL1DKQ44nrgRDCshbCbzWLPEWpDP+b48kJUjNV8aTmsuGSZwj Epi4Gf2deLANIilQZ6ezDHMVW86jzCQZOXoFORITnc70iFrFY33M0JuMRTukScNwOQNy X4gB4eAgXcs+Uu/dqzBmqjTLGqMZChiJgkP4gIXHuCqkQ5ipNAWm4I5HeUMRAQ5m3tM0 oHLjLDZg7zuqr9Nu6n8QfHJaLbmu4HfpbneHTLCPuiNmNrmE3jQu+NtCUKKISm/sRm0T ui46EuDqEZ8TuwP3W9jKcXJ8vOLG4B7W7RlnFLXj2RbLzyB9Iil0/KYARB4AFkc4oHa4 hnMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=4LfEBcFWA3guoTurZrkLBmYUUG9nybW+jTAI2lFQfeY=; b=jpS1dB7N1YhVgVe6Thy3WL31xEHQqz3OtjxPNcRkgpZ3shHd5gHyrPtVdHFoNnTPfM X5edrANGEdVWtbUZo/qC4FTia/k0ZLoOU9D3IORNg5cBo7edvPYBbfOWhNrY/bKCmC+P G2Bg8K+/JuKfACmf3kttsb6bQMsChje5dSl+cGENqDGg0+nlbYcDPSyZXwfE7KFmuhEY P+zoDTB9lY58+DR7Av6FXDTMwAljvb5Gvm6aPD7nz3/3YHT1oT6ar0LkaKERTRnFYxF7 kq+AojMwbpqqF4pPjGOnVON0TNY324G3g4QtVhjegFA9ZjzyiypOFYoKCsf4a/TTTsV5 27XQ== X-Gm-Message-State: AMCzsaURiipynRd68z8fPmIO18z+05oODNq8PG/2WeHZ5x8vyXgg9e/w g3WKjCVVZg7Kjr09WVARw25f0hok/Q== X-Google-Smtp-Source: ABhQp+SArWTdzWGma9ydgBOIIro4/ckayqTvAE0op4iUAhRZao42uxmycgHewjv3dE4AaKyO/iZROA== X-Received: by 10.28.206.142 with SMTP id e136mr4594469wmg.27.1508757496242; Mon, 23 Oct 2017 04:18:16 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v5sm4975463wrf.29.2017.10.23.04.18.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Oct 2017 04:18:15 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil , ivan.boule@6wind.com, stable@dpdk.org Date: Mon, 23 Oct 2017 13:17:56 +0200 Message-Id: <441cee59d3e6f9d1af231ea0a770a2fb316a2e7a.1508757360.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v3 2/3] app/testpmd: fix RSS structure initialisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 11:18:17 -0000 Struct rss_conf.rss_key_len is not initialised forcing the user to verify the rss_conf.rss_key pointer to know if the key is present or not. rss_conf.rss_key_len should have a valid length according to the size of the rss_key pointed. Fixes: 560e02ee5237 ("app/testpmd: configure RSS without restart") Cc: ivan.boule@6wind.com Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index bb01e989a..7002ff2c1 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1750,7 +1750,7 @@ cmd_config_rss_parsed(void *parsed_result, __attribute__((unused)) void *data) { struct cmd_config_rss *res = parsed_result; - struct rte_eth_rss_conf rss_conf; + struct rte_eth_rss_conf rss_conf = { .rss_key_len = 0, }; int diag; uint8_t i; -- 2.11.0