From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E6F66A0548;
	Wed, 15 Jun 2022 09:06:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DA404410D3;
	Wed, 15 Jun 2022 09:06:31 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id AECB940220
 for <dev@dpdk.org>; Wed, 15 Jun 2022 09:06:30 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 36D7B320027A;
 Wed, 15 Jun 2022 03:06:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Wed, 15 Jun 2022 03:06:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm2; t=1655276788; x=
 1655363188; bh=7iblq9OWwif23maWzQ42DC6yBExBp1YDh3cipAh/d3c=; b=N
 B9yHhU2i0fhfVmLVSkQDd6F/BjLyUWFZOUdXbGReGIEVwOycRlr/RKDp99Daj0CU
 0zQoW6n/tNVAKqan0ZrLnRB5NpnaVafIC5HvdutxPp26LFJWF5To24J8jMhKTWvJ
 P65GhfRy3sl9NF5Ya4VuMsZJkZeZ5C0cCm8P+isgAdFmqf9Die+17uBhfHGGIN54
 0nmpNgknes7TF9uHfShUgIvDYvq5isMktA4vGCahjyUu0Ky/TffADR4qsRHiMZT0
 64l0wlCaGjuIvV/lMwNIdwm2YqvxYjC5ICPSHxvVbPXfiWE+R8QSchTgMXknxuGU
 X2rB79rIeJAQOy/2IJmSQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655276788; x=
 1655363188; bh=7iblq9OWwif23maWzQ42DC6yBExBp1YDh3cipAh/d3c=; b=c
 veKxl0jpcufcGmEpT9scdmHaoPPlJnkspoNtp+wLYlCL/5lu8Uph/RGeLYxxM6Zk
 lgaGCTUdRPk5ONorzFvZ6BbUWYnzdZ/wQ5DDTMuXn+D/3mN0bhPSMLwYH8i7Otmh
 EBR8b/saZsmmlH9wf4c2CAvXyYzmic3H1xE9yC09Vev2mOO4N20o+uEGjAeIy1oE
 RKBKyckqqRVRKDgENJ8Zlt9Lb658f6lemgEYzJJ6ThHHIPGvSr4UhB6dcaCNhywW
 Xu+IzXjByBxejzivKPdgzcOWJCLyFPp5jRaY7LoiJTY3YKB4Gr4o3xXci/8nhI2T
 6F3tYAexhGPLZ9DOo4zKA==
X-ME-Sender: <xms:9ISpYlVNR62N-aPfmqVLIYVB19xYDGOpoi2B6S3AI602A4QIJgy7Xw>
 <xme:9ISpYllnKB8kCNPFLRKJEf1V-M1rzPnV8RSZ-pF3MalXnOVL9_IoMDvBkeez1VHy1
 M--TJCjzt36B4up7g>
X-ME-Received: <xmr:9ISpYhZPevzZy0iwQEu7mIi2YfcM3iGeZtji56N6YusiiaRhHy8HTVrR74mXsRwh-waXLGpy177yNoh8U_3KrKcgFQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvtddguddutdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho
 mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
 cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt
 ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:9ISpYoXcTKRzAufk9MDRMZwYCnadMhjJ1NuXoCh-x5noD0dx6GMOog>
 <xmx:9ISpYvkmud8VId6s1eCXKVMLs7S37R8tDouQgP_HLeJkB-F53vQKPw>
 <xmx:9ISpYlfqS_ccKw3smkNmK3Rw_dHPTL8pbYrSziCI9db8hDqTmvrITg>
 <xmx:9ISpYqu2kTSIFQnNyM7WQAhX6eoAr36VUOxgzMQmcwAQhsDr73H_fw>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 15 Jun 2022 03:06:27 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,
 Satha Rao <skoteshwar@marvell.com>
Subject: Re: [PATCH 2/2] common/cnxk: add include for macro definition
Date: Wed, 15 Jun 2022 09:06:26 +0200
Message-ID: <4422106.LvFx2qVVIh@thomas>
In-Reply-To: <20220614122904.159946-3-bruce.richardson@intel.com>
References: <20220614122904.159946-1-bruce.richardson@intel.com>
 <20220614122904.159946-3-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

14/06/2022 14:29, Bruce Richardson:
> The header file "roc_io.h" uses the "__plt_always_inline" macro but
> don't include "roc_platform.h" to get the definition of it. This
> inclusion is not necessary for compilation, but the lack of it can
> confuse some indexers - such as those in eclipse, which reports the
> lines:
> 
> "static __plt_always_inline uint64_t"
> 
> as possible definitions of a variable called "uint64_t". This confusion
> leads to uint64_t being flagged as an unknown type in all other parts of
> the project being indexed, e.g. across all of DPDK code.
> 
> Adding in the include of rte_common.h makes it clear to the indexer that
> those lines are  part of a function definition, and that allows eclipse
> to correctly recognise uint64_t as a type from stdint.h

It is not rte_common.h
Looks like a copy past of the first patch.