From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 6773E591F for ; Fri, 25 Nov 2016 14:09:24 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id f82so91502125wmf.1 for ; Fri, 25 Nov 2016 05:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=rK3V86NLABDnl8xYefbDg1kSF2xeefU2pFuiV/gV9eA=; b=W2JLlbgP+YkuTZDIXM8pQ12I/qqHU/KfYecJslf/nGrHykVAQDrWVTsI+BNF8byUBu ISAq8FliC9Jn1RkbD1c+OfCPNk3A6TL2rzfjJz8UnO1teSoQRXTHSpppQOJRDdYVB3MU 4EeRQkszxVy63AhevjtLA3bEkDbRVleEfjIc1u/JCvLC1lUk5+/eE3pUMv5Mk1u85Fgo aLjQ6DpHS1SOTcIpJ1V/0SI0ueneQdKBW1OgfDPtXv3gS+G8/c7I16Gnmv6kn5dL0jMM zL2HtmkwdkgilSRL06WetrbOTYaKIfnoCCeD0buC3yWrRCfYo1RfrUR9QsYR4+SU6t36 n2TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=rK3V86NLABDnl8xYefbDg1kSF2xeefU2pFuiV/gV9eA=; b=CcYxJVWhuLO0J2LCP6kIpJTUGaFkoJx7/Ek089Tv3rjZhliTCHUxtmUt7JUJUVQ5rg 7JerCxgUMEFuuomrzud20a8yEQWx8sPMYh/pyJMEaJYAHgjVNq2MeXjg85loTpu6BomC eUVpYE5TSMRCUkNxIAO6m4kL+LmUK/+YPbUeFcTVIDLoEUE7SpDFNhHGr93upvE+dgRG hGgEI7clu3YhILjMQh9XkLgACoEEowgnrBA3GlakcqXuFoexBhW3rOGMdl2bdoAykxO+ uSWaJrM1mZVXtDdqXrfRZAPI9YL8ilmglHyYQZYOCw1UKOjpdNi+oyYv70q8BSjEGETt 0k8w== X-Gm-Message-State: AKaTC00KI6jhxoMi4RGEmrUAEfPpbI/WLMdCH3K+rPyQT+brtP0EJ+mqxbwUWAT4uz3UzlhR X-Received: by 10.28.18.129 with SMTP id 123mr7195986wms.2.1480079364025; Fri, 25 Nov 2016 05:09:24 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b7sm47007193wjm.39.2016.11.25.05.09.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Nov 2016 05:09:23 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson , Jerin Jacob Cc: dev@dpdk.org, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, gage.eads@intel.com Date: Fri, 25 Nov 2016 14:09:22 +0100 Message-ID: <4424470.41x0ShzqNA@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161125110053.GA149796@bricha3-MOBL3.ger.corp.intel.com> References: <1479447902-3700-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161125002334.GA21048@svelivela-lt.caveonetworks.com> <20161125110053.GA149796@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 13:09:24 -0000 2016-11-25 11:00, Bruce Richardson: > On Fri, Nov 25, 2016 at 05:53:34AM +0530, Jerin Jacob wrote: > > On Thu, Nov 24, 2016 at 04:35:56PM +0100, Thomas Monjalon wrote: > > > 2016-11-24 07:29, Jerin Jacob: > > > > On Wed, Nov 23, 2016 at 07:39:09PM +0100, Thomas Monjalon wrote: > > > > > 2016-11-18 11:14, Jerin Jacob: > > > > > > +#define EVENTDEV_NAME_SKELETON_PMD event_skeleton > > > > > > +/**< Skeleton event device PMD name */ > > > > > > > > > > I do not understand this #define. > > > > > > > > Applications can explicitly request the a specific driver though driver > > > > name. This will go as argument to rte_event_dev_get_dev_id(const char *name). > > > > The reason for keeping this #define in rte_eventdev.h is that, > > > > application needs to include only rte_eventdev.h not rte_eventdev_pmd.h. > > > > > > So each driver must register its name in the API? > > > Is it really needed? > > > > Otherwise how application knows the name of the driver. > > The similar scheme used in cryptodev. > > http://dpdk.org/browse/dpdk/tree/lib/librte_cryptodev/rte_cryptodev.h#n53 > > No strong opinion here. Open for suggestions. > > > > I like having a name registered. I think we need a scheme where an app > can find and use an implementation using a specific driver. I do not like having the driver names in the API. An API should not know its drivers. If an application do some driver-specific processing, it knows the driver name as well. The driver name is written in the driver.