From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0585FA04C0;
Tue, 6 Oct 2020 22:32:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 62A841023;
Tue, 6 Oct 2020 22:32:20 +0200 (CEST)
Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com
[66.111.4.229]) by dpdk.org (Postfix) with ESMTP id D29F8E07;
Tue, 6 Oct 2020 22:32:17 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailnew.nyi.internal (Postfix) with ESMTP id 446D058025A;
Tue, 6 Oct 2020 16:32:16 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Tue, 06 Oct 2020 16:32:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
NeKEuSynoXKIDusGBwzp33GqswEX2B4t9J7tsfkJT78=; b=MmzdFhSxs+lIPFrc
daIe+KFksmeeeeAFXmxYMy6TCddoRDHCjT35o4I9fhx4uP2XxuHxUznypOGcnaqb
Y2+R5uoTwOgyaEPgwxn0GJ+KPgCfhbpoosc/C+rEXUZ/53CScSjexu2K5zmVXp+B
Y1TFKwvcFiVndAOInpLE0lK15I35S0uQQu/rIe/bfWwOzhQo8/rXt0MhPkeHHkM0
FA3hHu1huAVWW1OlfpydplsSl1fe8NMCDqjdEhRIyOOGsSztCMztX0vM8H5HkroB
2f+mYpEKqU4aOzv3iTwjk6SfniUfG0MCbEI7dcYMTuW9bzdV5f1lwSMav9elol04
8rQqSg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=NeKEuSynoXKIDusGBwzp33GqswEX2B4t9J7tsfkJT
78=; b=OoNweqTEyepOha3svfjLj5DlLV9tKagibrSBx8QrZ8fuV0g1Uw0s1/YLY
Kw354YM2p04gjuKHs88JUsBT0Rt2cKecSIuC3lyzziETGiBXnw9g+kWnOvuVDrt2
JdCTwRVCsHkuuJ3foZ6aPXvl4Z5LPSjOlTaiMm4XA87FEUphQDOWcMchlnFkh3if
ZZW7Evajk5wTOLKYi8ES+lKFvfhSZdQ4IJR0sMYni/D899joDhAQgqrpB1cm/D8E
TslmjaG5eC09UTfGWwacdg1wAk5ZaQOD+wb2HrAFNZXYIJk7rhTTPTSJUuFmnVqH
tlaK7KeEa2qnMyPlPGXLkLHiBiGFg==
X-ME-Sender: <xms:T9R8X2K4Lq5tSCloN_J3cdCinywIIpgzEn5xZuOUZx6AIE2DwHZnlQ>
<xme:T9R8X-Kp2mFk1Cvmj4et5lTWhQ8zCVL6D97RnzrJF5dioxTOiaT_0M-3xYzd9a_Nz
ydjo0Q5eZbTIpAsGg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggddugeekucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:T9R8X2u5c64HTjp6001iQVZjB6J28HUmNN0F1_nH8qqSPmqSGcKJNQ>
<xmx:T9R8X7aAYz02Uad0IoPkpT7tTDOZUTY_zWkyvZpIc7-fHtKiiu-n-w>
<xmx:T9R8X9YVDUH7wok8d1eY_bvuu7SJKNXMeqj14L8DaoLQd5u3BTD5ZQ>
<xmx:UNR8X6TJ3FOBHpug5XwvDdNXMkXNkgu3CM4-dIBI8gVoRWX16eDTCA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 4C1D23064680;
Tue, 6 Oct 2020 16:32:14 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Power <ciara.power@intel.com>
Cc: dev@dpdk.org, mike.ximing.chen@intel.com, gage.eads@intel.com,
sundar.vedantham@intel.com, stable@dpdk.org,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Nipun Gupta <nipun.gupta@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
Kevin Laatz <kevin.laatz@intel.com>, Keith Wiles <keith.wiles@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Date: Tue, 06 Oct 2020 22:32:13 +0200
Message-ID: <4426544.Le7519ogoN@thomas>
In-Reply-To: <20200827091431.GB569@bricha3-MOBL.ger.corp.intel.com>
References: <20200827083922.64442-1-ciara.power@intel.com>
<20200827091431.GB569@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: fix passing full params
string to command
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
27/08/2020 11:14, Bruce Richardson:
> On Thu, Aug 27, 2020 at 09:39:22AM +0100, Ciara Power wrote:
> > Telemetry only passed the first param to the command handler if multiple
> > were entered by the user, separated by commas. Telemetry is required to
> > pass the full params string to the command, by splitting by a comma
> > delimiter only once to remove the command part of the string. This will
> > enable future commands to take multiple param values.
> >
> > Fixes: b1ad0e124536 ("rawdev: add telemetry callbacks")
> > Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks")
> > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> >
> Missed threading with V1, but otherwise LGTM.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks